Page MenuHomePhabricator

On wiki talk pages using the Talkpageheader, emptystate message may be incorrectly added twice
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
emptyState message may be incorrectly added twice, one in #mw-content-text > .mw-talkpageheader > .ext-discussiontools-emptystate, another in #mw-content-text > .mw-parser-output > .ext-discussiontools-emptystate

image.png (1,686×846 px, 172 KB)

image.png (1,700×488 px, 114 KB)

What should have happened instead?:
emptystate within mw-talkpageheader should not exist

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This seemed to have been solved in rEDTO06aa46d, but the relevant code disappeared.

Event Timeline

Change #1064783 had a related patch set uploaded (by Bartosz Dziewoński; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Revert "Invert logic on empty talk page"

https://gerrit.wikimedia.org/r/1064783

Change #1064783 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Revert "Invert logic on empty talk page"

https://gerrit.wikimedia.org/r/1064783

@matmarex: 1.43.0-wmf.19 is already deployed on all groups so I'm going to remove that as a parent again - just a heads-up in case this is backport-worthy :)

Yeah, that was kind of a note-to-self that I should make a backport once it merges.

Change #1064827 had a related patch set uploaded (by Bartosz Dziewoński; author: DLynch):

[mediawiki/extensions/DiscussionTools@wmf/1.43.0-wmf.19] Revert "Invert logic on empty talk page"

https://gerrit.wikimedia.org/r/1064827

Change #1064827 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.43.0-wmf.19] Revert "Invert logic on empty talk page"

https://gerrit.wikimedia.org/r/1064827

Mentioned in SAL (#wikimedia-operations) [2024-08-22T20:19:18Z] <cdanis@deploy1003> Started scap sync-world: Backport for [[gerrit:1064827|Revert "Invert logic on empty talk page" (T373100)]]

Mentioned in SAL (#wikimedia-operations) [2024-08-22T20:21:32Z] <cdanis@deploy1003> matmarex, cdanis: Backport for [[gerrit:1064827|Revert "Invert logic on empty talk page" (T373100)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-08-22T20:26:33Z] <cdanis@deploy1003> Finished scap sync-world: Backport for [[gerrit:1064827|Revert "Invert logic on empty talk page" (T373100)]] (duration: 07m 16s)

Thank you for the bug report!