Page MenuHomePhabricator

Use ESM in core for selenium tests
Closed, ResolvedPublic1 Estimated Story Points

Description

TODO

Notes

From: https://nodejs.org/docs/latest-v22.x/api/esm.html#introduction

ECMAScript modules are the official standard format to package JavaScript code for reuse.

When including modules, we currently use require. All WebdriverIO documentation uses import. To simplify things, we should use import in our WebdriverIO tests.

Links:

Event Timeline

zeljkofilipin changed the task status from Open to In Progress.Aug 26 2024, 9:55 AM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as Low priority.
zeljkofilipin moved this task from Quarter 👔 to Deep work 🌊 on the User-zeljkofilipin board.

Change #1066709 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: Use import instead of require

https://gerrit.wikimedia.org/r/1066709

Change #1072148 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Main page should have "Log in" link

https://gerrit.wikimedia.org/r/1072148

Change #1072151 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Fix Main Page should have "Log in" link

https://gerrit.wikimedia.org/r/1072151

Change #1072148 merged by jenkins-bot:

[mediawiki/core@master] selenium: Main page should have "Log in" link

https://gerrit.wikimedia.org/r/1072148

Change #1072151 merged by jenkins-bot:

[mediawiki/core@master] selenium: Fix Main Page should have "Log in" link

https://gerrit.wikimedia.org/r/1072151

Change #1072499 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Fix docs/Stack/webdriverio.js

https://gerrit.wikimedia.org/r/1072499

Change #1072509 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: Don't use dotenv

https://gerrit.wikimedia.org/r/1072509

Change #1072499 merged by jenkins-bot:

[mediawiki/core@master] selenium: Fix docs/Stack/webdriverio.js

https://gerrit.wikimedia.org/r/1072499

zeljkofilipin changed the task status from In Progress to Open.Sep 13 2024, 9:28 AM
zeljkofilipin removed zeljkofilipin as the assignee of this task.
zeljkofilipin raised the priority of this task from Low to Needs Triage.
zeljkofilipin moved this task from Deep work 🌊 to Backlog 🪒 on the User-zeljkofilipin board.

Change #1066709 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Use import instead of require

https://gerrit.wikimedia.org/r/1066709

zeljkofilipin changed the task status from Open to In Progress.Jun 5 2025, 4:53 PM
zeljkofilipin claimed this task.
zeljkofilipin triaged this task as High priority.
zeljkofilipin moved this task from Backlog 🪒 to Shallow work 🍳 on the User-zeljkofilipin board.

Change #1066709 restored by Zfilipin:

[mediawiki/core@master] WIP selenium: Use import instead of require

https://gerrit.wikimedia.org/r/1066709

zeljkofilipin renamed this task from Use import instead of require to Use import instead of require in core.Jun 5 2025, 4:55 PM
zeljkofilipin removed a project: Epic.
zeljkofilipin renamed this task from Use import instead of require in core to Use ESM in core.Jun 10 2025, 11:00 AM
Jdforrester-WMF renamed this task from Use ESM in core to Use ESM in core for selenium tests.Jun 11 2025, 1:03 PM
zeljkofilipin set the point value for this task to 1.Jun 17 2025, 4:46 PM

Change #1066709 merged by jenkins-bot:

[mediawiki/core@master] selenium: Use ECMAScript modules

https://gerrit.wikimedia.org/r/1066709

Change #1164140 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] wdio-mediawiki: Release 5.0.0

https://gerrit.wikimedia.org/r/1164140

Change #1164140 merged by jenkins-bot:

[mediawiki/core@master] wdio-mediawiki: Release 5.0.0

https://gerrit.wikimedia.org/r/1164140

Suggestion for when the TODOs about minimizing diffs are addressed: the commit which reformats those files can be added to .git-blame-ignore-revs so it won't show up in git blame.

Change #1164431 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] selenium: Fix eslint-disable indent

https://gerrit.wikimedia.org/r/1164431

Change #1164431 merged by jenkins-bot:

[mediawiki/core@master] selenium: Fix eslint-disable indent

https://gerrit.wikimedia.org/r/1164431

Change #1164487 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Add recent wdio-mediawiki reformat to git-blame-ignore-revs

https://gerrit.wikimedia.org/r/1164487

Change #1164487 merged by jenkins-bot:

[mediawiki/core@master] Add recent wdio-mediawiki reformat to git-blame-ignore-revs

https://gerrit.wikimedia.org/r/1164487

Change #1072509 abandoned by Zfilipin:

[mediawiki/core@master] WIP selenium: Don't use dotenv

https://gerrit.wikimedia.org/r/1072509