Page MenuHomePhabricator
Create Task
Maniphest T373126

[S] iOS “picture of the day” widget, when clicked, does not have expected behavior
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • install the iOS app
  • install the “picture of the day” widget
  • click on the widget

What happens?:

opens the app and scrolls weirdly, usually going back to the top of the app but not always (but never scrolling to the actual picture-of-the-day location)

What should have happened instead?:

opens the app and scrolls to the picture of the day, or opens the website to the page for the picture

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
all iOS app versions for several years

Other information (browser name/version, screenshots, etc.):

Related Objects

Event Timeline

LuisVilla created this task.Aug 22 2024, 3:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2024, 3:47 PM
HNordeenWMF triaged this task as Low priority.Aug 27 2024, 8:46 PM
HNordeenWMF moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.
HNordeenWMF added a project: good first task.
HNordeenWMF subscribed.

Note: this may have been a regression introduced with this fix: https://phabricator.wikimedia.org/T371983.
On 7.5.8, Picture of the day worked after the app had been force closed, but not if the app is merely backgrounded.

Restricted Application added a comment. · View Herald TranscriptAug 27 2024, 8:47 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Seddon moved this task from Up next to iOS Release FY2024-25 on the Wikipedia-iOS-App-Backlog board.Sep 5 2024, 1:10 PM
Seddon edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.
Seddon moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
Seddon renamed this task from iOS “picture of the day” widget, when clicked, does not have expected behavior to [S] iOS “picture of the day” widget, when clicked, does not have expected behavior.Sep 10 2024, 2:04 PM
Seddon moved this task from Needs Eng Sync or Estimation to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
ChristianBilodeau claimed this task.Sep 10 2024, 2:46 PM
ChristianBilodeau added a comment.Sep 11 2024, 2:30 PM

Hello! This regression was seemingly introduced with this fix https://phabricator.wikimedia.org/T369567 (PR) and is present since version 7.5.6.

I've created this PR for a fix suggestion, I made some assumptions so please check the description for more details. Cheers!

ChristianBilodeau moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 11 2024, 2:30 PM
ChristianBilodeau moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
Tsevener moved this task from Needs Code Review to Did not pass Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 12 2024, 8:51 PM
ChristianBilodeau moved this task from Did not pass Code Review to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 13 2024, 3:14 PM
Tsevener removed ChristianBilodeau as the assignee of this task.Sep 13 2024, 3:30 PM
Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
Tsevener moved this task from Waiting for Build to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
Tsevener added a subscriber: ChristianBilodeau.
Tsevener mentioned this in T374666: Release `7.5.9`.Sep 13 2024, 8:50 PM
ABorbaWMF moved this task from Needs QA signoff to Ready for PM Signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 18 2024, 3:16 PM
ABorbaWMF subscribed.

Appears to be fixed on 7.5.9 (4067)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 19 2024, 12:36 AM

Thank you for contributing this fix @ChristianBilodeau !

HNordeenWMF closed this task as Resolved.Sep 23 2024, 3:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits