Page MenuHomePhabricator

Special:ManageMentors/edit-mentor - saving valid date for Away status produces incorrect "Your edit was ignored ..." notice
Closed, ResolvedPublicBUG REPORT

Description

Filed as a follow-up per @Pppery comment - https://phabricator.wikimedia.org/T370981#10083439
The issue is present on testwiki wmf.9
Steps:

  1. On betalabs wiki, as an admin go to Special:ManageMentors.
  2. Click on the Edit button to edit settings for a mentor with a custom introduction message.
  3. On Special:ManageMentors/edit-mentor/ [mentor userid] click the check box for Is away? status.
  4. Do not modify the custom introduction message of the mentor
  5. In the Away until field select any of the available days - click on Submit

What happened:

  • the notice "Your edit was ignored because no change was made to the text." appears
  • the selected date is saved
  • the Away status is actually set.

What should have happened:

  • no notice appears
  • The form is replaced with a basic message saying "Mentorship-related options for mentor XYZ were changed."
    • (We make should that message nicer. Codex success message styles?)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Uhoh... Thanks for filling! This would've been resolved with T347152, which was filled...quite a while ago. I guess it is time to take a look at it.

Etonkovidova updated the task description. (Show Details)

Re-checked on testwiki wmf.21 - the issue is not present anymore.
The messages to user provide correct information for the cases in the table below:

Date is not selected/enteredNo changes to the form are made
Screen Shot 2025-03-24 at 2.03.42 PM.png (1×1 px, 160 KB)
Screen Shot 2025-03-24 at 2.04.01 PM.png (1×1 px, 226 KB)

I note that the bug being reported here is not covered by that table - this bug is about when you do make changes.

My mistake, i corrected it. Thank you @Pppery for pointing it out. Usually I double-check if attached files are visible.

I note that the bug being reported here is not covered by that table - this bug is about when you do make changes.

Yes, I should've mentioned it, for sure. Along with this task, I was re-checking another issue and overall error handling.

The issue reported in this task has been fixed.

I can still reproduce this on enwiki.

image.png (690×1 px, 72 KB)

(Yes, I really was marking Martin Urbanec as away, since he was listed as an active mentor on enwiki despite not having responded to any mentee questions in about two years)

I can still reproduce this on enwiki.

image.png (690×1 px, 72 KB)

(Yes, I really was marking Martin Urbanec as away, since he was listed as an active mentor on enwiki despite not having responded to any mentee questions in about two years)

Yes, unfortunately, the issue is still there. The issue I see

  • as an admin go to Special:ManageMentors and click Edit to set/update/remove Away status for a mentor
  • when on the page Special:ManageMentors/edit-mentor/[userid], un-check/check the Is away? checkbox or modify the Away until field (entering a valid date).
  • click on Submit

What happened?

  • the message - Your edit was ignored because no change was made to the text. - is displayed
  • the updated status or the Away date is actually saved.

So, basically any update to Away status - setting it, modifying it, or removing it - produces that misleading Your edit was ignored because no change was made to the text.

But the updates are actually saved.

I had a quick look and now found out how to reproduce it. I've updated the description.

Michael changed the subtype of this task from "Task" to "Bug Report".Mar 28 2025, 5:32 PM

So, basically any update to Away status - setting it, modifying it, or removing it - produces that misleading Your edit was ignored because no change was made to the text.

But the updates are actually saved.

Another report T399182 - the initially set Away date cannot be changed.
(current behavior on testwiki wmf.9) If the Away date is changed (i.e. modified form the initially set date) via Special:ManageMentors/edit-mentor/[user_id] form

  • "Your edit was ignored ..." message appears
  • the page Special:ManageMentors/edit-mentor/[user_id] won't reflect the changes

So the issue is not only in the misleading message "Your edit was ignored ...", but in not being able to modify the Away date via Special:ManageMentors/edit-mentor/[user_id] form.
A workaround - a mentor can set any Away date from their Special:MentorshipDashboard, and those changes will be reflected on Special:ManageMentors.

The reason for this is because MW PageUpdater correctly computes that there's no change on the JSON blob we send for saving compared to the prior blob. That is because status away has its current data store (user options) but we always send an update to PageUpdater, even when only the status away has change in the form and no change is done to the json config blob. Once T347152 is resolved the warning notice should disappear and we should be fine. Also note that the current notice message is quite miss-leading as the status timestamp is indeed updated (because it's done on a separate transaction than the "failed" page update).