Page MenuHomePhabricator

Test Codex components with the expanded color palette
Closed, ResolvedPublic3 Estimated Story Points

Description

We need to test that the changes to the Codex color palette developed in T360494 do not cause any unintended consequences to the system.

Test environment

Acceptance Criteria

  • Visual regression testing of the expanded palette using Pixel results in expected changes to Codex components
  • Manual testing of the expanded palette in the sandbox results in expected changes to Codex components
  • Manual testing of the expanded palette in a patch demo results in expected changes to Codex components

Event Timeline

CCiufo-WMF added a subscriber: DTorsani-WMF.
CCiufo-WMF raised the priority of this task from High to Needs Triage.
CCiufo-WMF set the point value for this task to 3.Aug 26 2024, 5:09 PM
Volker_E subscribed.

There's an issue with the language button (a Codex fake button), it's partly already visible in production, but got worse with the color palette patch. Need to look closer to the fake button styles and the Vector implementation.

I have completed the visual color testing with components in Sandbox for both light and dark modes. There were a few remaining application and component token level updates needing to be made that I caught during this test. Those have been made now as a part of Patchset 7.

The only other elements whose colors are noticeably different after the color update, noticed during this Sandbox visual testing are:

  1. Progressive and Destructive elements such as links and buttons. The updated colors are lighter and less saturated. This is an intentional difference, but a noticeable one. More about our intentions for choosing colors for dark mode can be read in the color design documentation project page. This move to this shade of blue and red has also been requested by community members, as seen here and here.
  2. The Message background colors are a bit different in the updated color palette, in both light and dark modes. This is also an intentional shift, as the new palette enables us to bring a bit more saturation to these status colors, since they are meant to help convey meaning through the color.

Pixel tests (without surprises) were provided by @lwatson before releasing v0.13.0.

Volker_E updated the task description. (Show Details)