| Izno | |
| Aug 23 2024, 10:12 PM |
| F57605726: Screenshot from 2024-10-11 09-44-50.png | |
| Oct 11 2024, 7:50 AM |
| F57605725: Screenshot from 2024-10-11 09-44-45.png | |
| Oct 11 2024, 7:50 AM |
| F57600392: Screenshot from 2024-10-09 10-02-03.png | |
| Oct 9 2024, 8:08 AM |
| F57600390: Screenshot from 2024-10-09 09-57-56_.png | |
| Oct 9 2024, 8:08 AM |
Ending up in an edit conflict with two column merge turned on needs a dark mode treatment.
Some of the issues are:
For comparison, this is how diff and editor should look like (screenshot from the normal 2010 wikitext editor):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | BUG REPORT | None | T373231 Two column edit conflict needs dark mode | ||
| Resolved | WMDE-Fisch | T376801 Fix flaky TwoColConflict selenium tests |
Change #1078905 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] [WIP] Full fix for TwoColConflict in dark mode
Change #1078906 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Make use of more (non-color) LESS variables
Change #1078910 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Replace most problematic hard-coded colors with skin colors
Change #1078911 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Add notheme hack to make edit buttons visible in dark mode
Change #1078906 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Make use of more (non-color) LESS variables
Change #1078910 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Replace most problematic hard-coded colors with skin colors
Here is a comparison for what the quick, temporary notheme hack in https://gerrit.wikimedia.org/r/1078911 does:
I need help with the final patch https://gerrit.wikimedia.org/r/1078905. I can't get the LESS functions working. Why is that?
Change #1078911 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Add notheme hack to make edit buttons visible in dark mode