Page MenuHomePhabricator
Create Task
Maniphest T373271

Most CentralAuth maintenance classes are not namespaced, causing issues with maintenance/run.php
Closed, ResolvedPublic
Actions

Description

Currently php maintenance/run.php CentralAuth:migratePass0 fails with Fatal error: Cannot declare class MigratePass0, because the name is already in use in […]/extensions/CentralAuth/maintenance/migratePass0.php on line 18.

This is due to CentralAuth's extension.json declaring "MediaWiki\\Extension\\CentralAuth\\Maintenance\\": "maintenance/" in AutoloadNamespaces. Thus calling php maintenance/run.php CentralAuth:migratePass0 will make MediaWiki try to autoload extensions/CentralAuth/maintenance/migratePass0.php looking for MediaWiki\Extension\CentralAuth\Maintenance\migratePass0 (which it doesn't contain). The subsequent loading of the same script in MaintenanceRunner::loadScriptFile will then error out as shown above.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Namespace remaining maintenance scriptsmediawiki/extensions/CentralAuthmaster+111 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

hoo created this task.Aug 25 2024, 3:53 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 25 2024, 3:53 PM
hoo added a comment.Aug 25 2024, 3:57 PM

This was caused by 8006f0c5862b151f05682d4beca78e34076e93c2.

Reedy removed projects: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early), MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Aug 26 2024, 1:41 AM
matmarex claimed this task.Aug 26 2024, 1:07 PM
matmarex subscribed.

I suppose we should just namespace them.

gerritbot added a comment.Aug 26 2024, 1:35 PM

Change #1066774 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] Namespace remaining maintenance scripts

https://gerrit.wikimedia.org/r/1066774

gerritbot added a project: Patch-For-Review.Aug 26 2024, 1:35 PM
matmarex moved this task from Inbox, needs triage to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.Aug 26 2024, 2:44 PM
gerritbot added a comment.Aug 27 2024, 8:34 AM

Change #1066774 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Namespace remaining maintenance scripts

https://gerrit.wikimedia.org/r/1066774

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 27 2024, 9:00 AM
matmarex closed this task as Resolved.Aug 27 2024, 2:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits