Page MenuHomePhabricator

Show error message when a shortened URL prevents user from adding a topic or comment
Closed, ResolvedPublicFeature

Description

Steps to replicate the issue (include links if applicable):

What happens?:
It tries to save the message and never creates the topic. No error message or warning whatsoever.

What should have happened instead?:
Tell the user content in their message failed some checks and what those checks are so that user can update the message. In this case, Extension:SpamBlacklist prevented the user from posting a shortened URL.

Event Timeline

Saiphani02 changed the subtype of this task from "Bug Report" to "Feature Request".Aug 26 2024, 5:21 AM
Saiphani02 updated the task description. (Show Details)

Change #1066783 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] CommentController: fix a call to a missing setSaveErrorMessage

https://gerrit.wikimedia.org/r/1066783

Change #1066783 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] CommentController: fix a call to a missing setSaveErrorMessage

https://gerrit.wikimedia.org/r/1066783

Welp, it's still not working. Now the error is jQuery.Deferred exception: this.replyWidget.setSaveErrorMessage is not a function.

Change #1067429 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix missing definition of setSaveErrorMessage too

https://gerrit.wikimedia.org/r/1067429

Change #1067429 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix missing definition of setSaveErrorMessage too

https://gerrit.wikimedia.org/r/1067429

Change #1068052 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.43.0-wmf.20] Fix missing definition of setSaveErrorMessage too

https://gerrit.wikimedia.org/r/1068052

Change #1068052 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.43.0-wmf.20] Fix missing definition of setSaveErrorMessage too

https://gerrit.wikimedia.org/r/1068052

Mentioned in SAL (#wikimedia-operations) [2024-08-28T20:37:41Z] <cjming@deploy1003> Started scap sync-world: Backport for [[gerrit:1068051|auth: Relax AuthManager session state check while cde00b55 is deployed (T373504)]], [[gerrit:1068052|Fix missing definition of setSaveErrorMessage too (T373288)]], [[gerrit:1068041|CentralAuthApiSessionProvider: Avoid error in internal API requests (T373507)]]

Mentioned in SAL (#wikimedia-operations) [2024-08-28T20:39:45Z] <cjming@deploy1003> matmarex, cjming: Backport for [[gerrit:1068051|auth: Relax AuthManager session state check while cde00b55 is deployed (T373504)]], [[gerrit:1068052|Fix missing definition of setSaveErrorMessage too (T373288)]], [[gerrit:1068041|CentralAuthApiSessionProvider: Avoid error in internal API requests (T373507)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-08-28T20:49:13Z] <cjming@deploy1003> Finished scap sync-world: Backport for [[gerrit:1068051|auth: Relax AuthManager session state check while cde00b55 is deployed (T373504)]], [[gerrit:1068052|Fix missing definition of setSaveErrorMessage too (T373288)]], [[gerrit:1068041|CentralAuthApiSessionProvider: Avoid error in internal API requests (T373507)]] (duration: 11m 31s)