query->globalblocks sometimes intersperses empty arrays in result if queried for range
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Count_Count
	Aug 26 2024, 5:53 AM

Description

Steps to replicate the issue (include links if applicable):

Go to https://meta.wikimedia.org/w/api.php?action=query&list=globalblocks&bglimit=500&bgprop=range&bgstart=2024-08-23T02:27:29Z

What happens?:

Observe that the first item in the globalblocks array is an empty array instead of an object.

What should have happened instead?:

There should be no empty array there.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Mark globalblocks query results as associated	mediawiki/extensions/GlobalBlocking	master	+3 -1

Customize query in gerrit

Event Timeline

Count_Count created this task.Aug 26 2024, 5:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2024, 5:53 AM

Count_Count renamed this task from query->globalblocks intersperse empty arrays in result if queried for range to query->globalblocks sometimes intersperses empty arrays in result if queried for range.Aug 26 2024, 5:55 AM

Count_Count updated the task description. (Show Details)

The example block mentioned above has ID 3260612.
I did a query on Toolforge replica DBs and it seems that the block is for a user but not a IP address/range.

Therefore, the IP ranges are not available and not added: https://gerrit.wikimedia.org/g/mediawiki/extensions/GlobalBlocking/+/5e4bb5e1b2c61b58ef9950e31d599dac707e4e66/includes/Api/ApiQueryGlobalBlocks.php#220.

However I think the empty array should be serialized as a JSON object but not an array.

Change #1066588 had a related patch set uploaded (by XtexChooser; author: XtexChooser):

[mediawiki/extensions/GlobalBlocking@master] Mark globalblocks query results as associated

https://gerrit.wikimedia.org/r/1066588

gerritbot added a project: Patch-For-Review.Aug 26 2024, 7:19 AM

kostajh added a project: Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).Aug 26 2024, 8:23 AM

kostajh moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.

Change #1066588 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Mark globalblocks query results as associated

https://gerrit.wikimedia.org/r/1066588

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.20; 2024-08-27).Aug 26 2024, 9:00 AM

Count_Count updated the task description. (Show Details)Aug 27 2024, 6:35 AM

QA has been completed and the new code is functioning and displaying as expected.

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2024, 5:30 AM

• Dreamy_Jazz closed this task as Resolved.Aug 30 2024, 8:53 AM

• Dreamy_Jazz assigned this task to XtexChooser.

	F57353100: image.png
	Aug 30 2024, 5:29 AM

query->globalblocks sometimes intersperses empty arrays in result if queried for rangeClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

query->globalblocks sometimes intersperses empty arrays in result if queried for range
Closed, ResolvedPublicBUG REPORT
Actions