CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.43.0-wmf.16
reqId: 4083010f-ef55-452b-a847-6675f840bbcd
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled

exception.trace

from /srv/mediawiki/php-1.43.0-wmf.16/includes/user/ActorStore.php(638)
#0 /srv/mediawiki/php-1.43.0-wmf.16/includes/user/ActorStore.php(415): MediaWiki\User\ActorStore->validateActorForInsertion(MediaWiki\User\UserIdentityValue)
#1 /srv/mediawiki/php-1.43.0-wmf.16/includes/changes/RecentChange.php(452): MediaWiki\User\ActorStore->acquireActorId(MediaWiki\User\UserIdentityValue, Wikimedia\Rdbms\DBConnRef)
#2 /srv/mediawiki/php-1.43.0-wmf.16/includes/changes/CategoryMembershipChange.php(211): RecentChange->save()
#3 /srv/mediawiki/php-1.43.0-wmf.16/includes/changes/CategoryMembershipChange.php(147): CategoryMembershipChange->notifyCategorization(string, MediaWiki\Title\Title, MediaWiki\User\UserIdentityValue, string, MediaWiki\Title\Title, string, MediaWiki\Revision\RevisionStoreRecord, boolean)
#4 /srv/mediawiki/php-1.43.0-wmf.16/includes/changes/CategoryMembershipChange.php(116): CategoryMembershipChange->createRecentChangesEntry(MediaWiki\Title\Title, integer)
#5 /srv/mediawiki/php-1.43.0-wmf.16/includes/jobqueue/jobs/CategoryMembershipChangeJob.php(216): CategoryMembershipChange->triggerCategoryAddedNotification(MediaWiki\Title\Title)
#6 /srv/mediawiki/php-1.43.0-wmf.16/includes/jobqueue/jobs/CategoryMembershipChangeJob.php(167): CategoryMembershipChangeJob->notifyUpdatesForRevision(Wikimedia\Rdbms\LBFactoryMulti, WikiPage, MediaWiki\Revision\RevisionStoreRecord)
#7 /srv/mediawiki/php-1.43.0-wmf.16/extensions/EventBus/includes/JobExecutor.php(80): CategoryMembershipChangeJob->run()
#8 /srv/mediawiki/rpc/RunSingleJob.php(60): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#9 {main}

Impact

Notes

See T349219: [M] Investigate: Which workflows create an IP actor?.

Details

Request URL: https://mw-jobrunner.discovery.wmnet/rpc/RunSingleJob.php

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	recentchanges: Make CategoryMembershipChange constructor args required	mediawiki/core	master	+25 -95
	Use import actor store where needed in RC categorisation	mediawiki/core	master	+142 -11

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
			Restricted Task
Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
Resolved		Niharika	T324492 Temporary accounts - MVP
Resolved		Madalina	T326816 [Epic] Update features for temporary accounts
Resolved		Madalina	T331637 Update features in MediaWiki core for IP Masking
Resolved	PRODUCTION ERROR	• mszabo	T373318 CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled

Event Timeline

kostajh created this task.Aug 26 2024, 10:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 26 2024, 10:39 AM

Not sure if this is still a problem (error above was seen on August 1), but worth double checking.

I do not believe that this is fixed. Looking at the API, it seems that this was for an import of revisions.

What I'm thinking is going wrong:

An import occurs with revisions that contain IP addresses
The import succeeds, because we allow actor IDs for IP addresses on import
At least one of the IP revisions adds a category to the page, and wgRCWatchCategoryMembership is true.
This causes a CategoryMembershipChangeJob to be added for the imported revision
The job creates a RecentChange entry for the categorisation
This attempts to create an actor ID, but not using the actor store that allows creating IP address actors

thcipriani moved this task from Untriaged to Aug 2024 on the Wikimedia-production-error board.Aug 29 2024, 3:27 PM

kostajh added a project: Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).Sep 2 2024, 11:50 AM

Dreamy_Jazz edited parent tasks, added: T331637: Update features in MediaWiki core for IP Masking; removed: T349219: [M] Investigate: Which workflows create an IP actor?.Sep 11 2024, 1:56 PM

Dreamy_Jazz claimed this task.Sep 13 2024, 7:16 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).

Dreamy_Jazz set the point value for this task to 2.

Change #1072801 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] [WIP] Use import actor store where needed in RC categorisation

https://gerrit.wikimedia.org/r/1072801

gerritbot added a project: Patch-For-Review.Sep 13 2024, 7:39 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)); removed Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).Sep 13 2024, 7:40 PM

kostajh moved this task from Backlog to In progress on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Sep 16 2024, 8:41 AM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 16 2024, 10:10 AM

Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 18 2024, 6:44 PM

Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Sep 26 2024, 2:29 PM

• mszabo changed the task status from Open to In Progress.Sep 30 2024, 2:47 PM

• mszabo claimed this task.

• mszabo moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.

• mszabo moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Oct 1 2024, 10:51 PM

Change #1072801 merged by jenkins-bot:

[mediawiki/core@master] Use import actor store where needed in RC categorisation

https://gerrit.wikimedia.org/r/1072801

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2024, 3:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).Oct 3 2024, 4:00 PM

Change #1077987 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/core@master] recentchanges: Make CategoryMembershipChange constructor args required

https://gerrit.wikimedia.org/r/1077987

gerritbot added a project: Patch-For-Review.Oct 4 2024, 4:28 PM

Dreamy_Jazz moved this task from Sprint Beatboxing (Sept 16-27) to Sprint Cello (Oct 7 - 18) on the Trust and Safety Product Sprint board.Oct 8 2024, 10:29 AM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)); removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.

• mszabo moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)) board.Oct 17 2024, 9:03 PM

Ammarpad mentioned this in T377897: Flaky ImportTemporaryUserIntegrationTest.Oct 22 2024, 10:57 PM

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15); removed Trust and Safety Product Sprint (Sprint Cello (Oct 7 - 18)).Oct 28 2024, 11:05 AM

kostajh moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

kostajh moved this task from In progress to Done / QA on the Temporary accounts (Blockers to minor pilot wiki deployment) board.Oct 28 2024, 4:33 PM

I did not see an exception when importing an article which had an IP edit which added a category.

Test environment:

local docker (importing from enrtlwiki beta) MediaWiki 1.44.0-alpha (f0dfd5e) 07:04, 1 November 2024.
https://en.wikipedia.beta.wmflabs.org (importing from testwiki) MediaWiki 1.44.0-alpha (f0dfd5e) 07:04, 1 November 2024.