Page MenuHomePhabricator

Remove feature flag for hiding invitation list special pages
Closed, ResolvedPublic

Description

When T373041 passes QA, the CampaignEventsShowEventInvitationSpecialPages config flag (which controls whether the invitation list special pages are shown) can be removed from the source code and WMF config.

  • Remove flag from code
  • Remove flag from beta configuration
  • Remove flag from production configuration

Event Timeline

Change #1077368 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Remove temporary feature flag for invitation list special pages

https://gerrit.wikimedia.org/r/1077368

Change #1077370 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] beta: Drop $wgCampaignEventsShowEventInvitationSpecialPages

https://gerrit.wikimedia.org/r/1077370

Change #1077371 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] prod: Drop $wgCampaignEventsShowEventInvitationSpecialPages

https://gerrit.wikimedia.org/r/1077371

Change #1077368 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Remove temporary feature flag for invitation list special pages

https://gerrit.wikimedia.org/r/1077368

I'm not sure why that would happen, all references to the SpecialPageInitListHandler class have been removed. Probably some sort of caching issue, especially considering the fact that it already fixed itself on the next run.

Let's wait for a train or two before cleaning up the WMF config.

Scheduled for next Monday (Oct 28) 13:00 UTC.

Change #1077370 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Drop $wgCampaignEventsShowEventInvitationSpecialPages

https://gerrit.wikimedia.org/r/1077370

Change #1077371 merged by jenkins-bot:

[operations/mediawiki-config@master] prod: Drop $wgCampaignEventsShowEventInvitationSpecialPages

https://gerrit.wikimedia.org/r/1077371

Mentioned in SAL (#wikimedia-operations) [2024-10-28T13:27:18Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1083170|Enable CampaignEvents collaboration list by default (T375141)]], [[gerrit:1077370|beta: Drop $wgCampaignEventsShowEventInvitationSpecialPages (T373442)]], [[gerrit:1077371|prod: Drop $wgCampaignEventsShowEventInvitationSpecialPages (T373442)]]

Mentioned in SAL (#wikimedia-operations) [2024-10-28T13:29:29Z] <urbanecm@deploy2002> urbanecm, daimona: Backport for [[gerrit:1083170|Enable CampaignEvents collaboration list by default (T375141)]], [[gerrit:1077370|beta: Drop $wgCampaignEventsShowEventInvitationSpecialPages (T373442)]], [[gerrit:1077371|prod: Drop $wgCampaignEventsShowEventInvitationSpecialPages (T373442)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-10-28T13:41:01Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1083170|Enable CampaignEvents collaboration list by default (T375141)]], [[gerrit:1077370|beta: Drop $wgCampaignEventsShowEventInvitationSpecialPages (T373442)]], [[gerrit:1077371|prod: Drop $wgCampaignEventsShowEventInvitationSpecialPages (T373442)]] (duration: 13m 43s)

QA notes: just make sure invitation lists are still enabled and working as before.

vaughnwalters subscribed.

Lists are generating and display as expected in beta and prod, marking as done / resolved