Page MenuHomePhabricator

MPIC: Update instruments table to include variants json column
Closed, ResolvedPublic2 Estimated Story Points

Description

T370880

Description

In order to start talking about experiments in mpic, we need a way to include feature variants in the upcoming experiments form.
As a precursor to this work, a new variants column should be added to the instruments table. This field should be a json type nullable value.

The structure of the variants json field will include name, type, values and will be handled by the instrument store for serialization/deserialization in T373467

Example value for variants:

{
  "name": "color",
  "type": "string",
  "values": [
    "red",
    "blue",
   "green
  ]
}

Acceptance Criteria

  • db.sql file is updated to include this new column
  • schema_type, schema_title and stream_name are considered as non-mandatory columns
  • Inserts should include test data for this field
  • Staging + Production databases are updated accordingly (we have to do this before deploying to the respective environment)

Required

  • Unit/Integration tests?
  • Documentation?
  • Passed QA?

Event Timeline

cjming updated the task description. (Show Details)
This comment was removed by SGupta-WMF.
Sfaci subscribed.

I have updated the ticket description to add a new AC (it was mentioned in the Alpha Plan doc but no here in the ticket):

  • schema_type, schema_title and stream_name are considered as non-mandatory columns
SGupta-WMF updated Other Assignee, added: cjming.
SGupta-WMF subscribed.
Sfaci updated the task description. (Show Details)

Our future selves should keep in mind that we have to update databases for the respective environments (staging and production) before deploy there

Change #1075207 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying on staging a new relase v0.2

https://gerrit.wikimedia.org/r/1075207

Change #1075207 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying on staging a new relase v0.2

https://gerrit.wikimedia.org/r/1075207

Change #1075524 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying to production a new relase v0.2

https://gerrit.wikimedia.org/r/1075524

Change #1075524 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying to production a new relase v0.2

https://gerrit.wikimedia.org/r/1075524