Page MenuHomePhabricator

MPIC: Remove `Type` from instrument form
Closed, ResolvedPublic2 Estimated Story Points

Description

T370880

Description

As a result of T373466 and T373467, we should remove the Type field from the instrument form.

We can also remove the Type property from the public instruments api response.

The revised instruments api response can be derived by filtering on Type === baseline.

Acceptance Criteria

  • The Type field is removed from the front end of the instrument form and the public api response.
  • The type field remains as a field in the instrument store and database table.
  • Update instruments api endpoint to filter on Type === baseline
  • Update validators

Required

  • Unit/Integration tests?
  • Documentation?
  • Passed QA?

Event Timeline

VirginiaPoundstone lowered the priority of this task from High to Medium.Sep 9 2024, 7:11 PM
Sfaci removed Sfaci as the assignee of this task.Sep 10 2024, 7:30 AM
Sfaci subscribed.

Change #1075207 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying on staging a new relase v0.2

https://gerrit.wikimedia.org/r/1075207

Change #1075207 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying on staging a new relase v0.2

https://gerrit.wikimedia.org/r/1075207

Change #1075524 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying to production a new relase v0.2

https://gerrit.wikimedia.org/r/1075524

Change #1075524 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying to production a new relase v0.2

https://gerrit.wikimedia.org/r/1075524