Cannot require undefined file ../contributionEvents.js
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 27 2024, 7:55 PM

Project Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=T352930

What happens?:
Error in console:

Error: Cannot require undefined file ../contributionEvents.js
    at require (startup.js:1006:11)
    at StoryViewer.vue (StoryViewer.vue:12:28)
    at require (startup.js:1013:5)
    at index.js (index.js:2:21)
    at runScript (startup.js:1279:6)
    at Array.<anonymous> (startup.js:1348:6)
    at flushCssBuffer (startup.js:597:28)

What should have happened instead?:
no error.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Simplify shared files declaration in modules definition	Sbisson	mediawiki/extensions/Wikistories	master	+33 -73
	Fix instrumentation file path	Sbisson	mediawiki/extensions/Wikistories	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T373065: require('../bar/baz.js') fails from top of module directory
T373482: [Regression] JS error on page load on create account page

Event Timeline

Jdlrobson created this task.Aug 27 2024, 7:55 PM

Herald added a subscriber: Aklapper. · View Herald TranscriptAug 27 2024, 7:55 PM

Change #1067418 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Fix instrumentation file path

https://gerrit.wikimedia.org/r/1067418

gerritbot added a project: Patch-For-Review.Aug 27 2024, 8:12 PM

Pinging @hueitan and @eamedina for code review

Jdlrobson mentioned this in T373482: [Regression] JS error on page load on create account page.Aug 27 2024, 10:00 PM

@SBisson I notice the definition of this module looks a bit odd:

"ext.wikistories.viewer": {
			"localBasePath": "resources/ext.wikistories.viewer",
			"packageFiles": [
				"index.js",
				"StoryViewer.vue",
				{
					"name": "consumptionEvents.js",
					"file": "../instrumentation/consumptionEvents.js"
				},
				{
					"name": "contributionEvents.js",
					"file": "../instrumentation/contributionEvents.js"
				},

While the above works fine, I'd love the know if the following also works. If not, I'd welcome a MediaWiki-ResourceLoader bug report as this imho should work!

"ext.wikistories.viewer": {
			"localBasePath": "resources/ext.wikistories.viewer",
			"packageFiles": [
				"index.js",
				"StoryViewer.vue",
				"../instrumentation/consumptionEvents.js"
				"../instrumentation/contributionEvents.js"

Change #1067418 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Fix instrumentation file path

https://gerrit.wikimedia.org/r/1067418

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 28 2024, 5:00 AM

Change #1067994 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Simplify shared files declaration in modules definition

https://gerrit.wikimedia.org/r/1067994

In T373481#10098593, @Krinkle wrote:

While the above works fine, I'd love the know if the following also works. If not, I'd welcome a MediaWiki-ResourceLoader bug report as this imho should work!
"ext.wikistories.viewer": {
			"localBasePath": "resources/ext.wikistories.viewer",
			"packageFiles": [
				"index.js",
				"StoryViewer.vue",
				"../instrumentation/consumptionEvents.js"
				"../instrumentation/contributionEvents.js"

It seems to work just fine as illustrated in the patch linked above. Of course it makes the require statements more verbose but it's just loading the files from where they actually are so there is nothing wrong with that.

Krinkle mentioned this in T373065: require('../bar/baz.js') fails from top of module directory.Aug 28 2024, 6:19 PM

thcipriani moved this task from Untriaged to Aug 2024 on the Wikimedia-production-error board.Aug 29 2024, 3:30 PM

Change #1067994 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Simplify shared files declaration in modules definition

https://gerrit.wikimedia.org/r/1067994

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.23; 2024-09-17); removed: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 13 2024, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2024, 10:30 AM

Krinkle closed this task as Resolved.Sep 14 2024, 12:23 AM

abi_ moved this task from Needs Review to Done on the LPL Essential (LPL Essential 2024 Jul-Oct) board.Sep 17 2024, 4:37 AM

Cannot require undefined file ../contributionEvents.jsClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Cannot require undefined file ../contributionEvents.js
Closed, ResolvedPublicBUG REPORT
Actions