Page MenuHomePhabricator

Support temporary account-related logs from other extensions in CheckUser
Closed, ResolvedPublic

Description

AbuseFilter will begin logging temporary account IP views in T365743: Log when AbuseFilter user sees IP address associated with temp account via user_unnamed_ip variable trigger in its own log. It would be convenient and nice if all logs with regards to temporary account IPs were centralized in order to make it easier to review. Right now there's no way to use CheckUser's TemporaryAccountLogger to accurately record other IP viewing-related actions. Given that CheckUser is the holder of temporary account IP data, we should log to CheckUser whenever possible.

CheckUser will have to be aware of the extensions writing to it via the internationalization files. Otherwise, it would need to pull the message from the other extension and if that extension (and its localization files) were removed/disabled, then the logs provided by CheckUser would be broken. There is precedence for CheckUser/other extensions knowing each other exists and containing it to the localization files seems to be the solution with the least fallout.

Acceptance criteria:

  • TemporaryAccountLogger can take a log type/message key from an external source and write the relevant message to the temporary accounts log

Event Timeline

Change #1069146 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Support other extensions writing to temporary account logs

https://gerrit.wikimedia.org/r/1069146

Change #1069146 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Support other extensions writing to temporary account logs

https://gerrit.wikimedia.org/r/1069146

dom_walden subscribed.

While testing T365743, I saw AbuseFilter logs being recorded in the CheckUser temporary account log on my local docker environment.