Page MenuHomePhabricator
Create Task
Maniphest T373596

Hard-deprecate all methods in the GlobalBlocking static utility class
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The GlobalBlocking extension has a static utility class which only contains deprecated methods. Some of these are hard deprecated, but ideally they should all be hard deprecated to allow removal of this class and its methods in a future version.

Acceptance criteria
  • Mark all methods of the GlobalBlocking static utility class as hard deprecated

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace removed globalblocking blocked text message keysmediawiki/extensions/WikimediaEventsmaster+18 -14
Hard deprecate GlobalBlocking::getUserBlockmediawiki/extensions/GlobalBlockingmaster+1 -0
Replace GlobalBlocking::getUserBlock in AbstractCheckUserPagermediawiki/extensions/CheckUsermaster+56 -14
Remove usage of deprecated GlobalBlocking::getUserBlockmediawiki/extensions/FileImportermaster+0 -11
Hard deprecate all GlobalBlocking methods except ::getUserBlockmediawiki/extensions/GlobalBlockingmaster+8 -10
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Aug 29 2024, 1:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2024, 1:38 PM
gerritbot added a comment.Aug 29 2024, 1:40 PM

Change #1068781 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Hard deprecate all GlobalBlocking methods except ::getUserBlock

https://gerrit.wikimedia.org/r/1068781

gerritbot added a project: Patch-For-Review.Aug 29 2024, 1:40 PM
gerritbot added a comment.Aug 29 2024, 2:08 PM

Change #1068791 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Replace GlobalBlocking::getUserBlock in AbstractCheckUserPager

https://gerrit.wikimedia.org/r/1068791

gerritbot added a comment.Aug 29 2024, 2:28 PM

Change #1068796 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/FileImporter@master] Remove usage of deprecated GlobalBlocking::getUserBlock

https://gerrit.wikimedia.org/r/1068796

gerritbot added a comment.Aug 29 2024, 2:34 PM

Change #1068797 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaEvents@master] Replace removed globalblocking blocked text message keys

https://gerrit.wikimedia.org/r/1068797

Dreamy_Jazz set the point value for this task to 1.Aug 29 2024, 2:35 PM
gerritbot added a comment.Aug 29 2024, 2:38 PM

Change #1068799 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Hard deprecate GlobalBlocking::getUserBlock

https://gerrit.wikimedia.org/r/1068799

gerritbot added a comment.Aug 29 2024, 2:47 PM

Change #1068781 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Hard deprecate all GlobalBlocking methods except ::getUserBlock

https://gerrit.wikimedia.org/r/1068781

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 29 2024, 3:00 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Aug 30 2024, 12:25 PM
Jdforrester-WMF updated the task description. (Show Details)Aug 30 2024, 7:46 PM
gerritbot added a comment.Aug 30 2024, 8:18 PM

Change #1068796 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Remove usage of deprecated GlobalBlocking::getUserBlock

https://gerrit.wikimedia.org/r/1068796

gerritbot added a comment.Aug 30 2024, 8:23 PM

Change #1068791 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Replace GlobalBlocking::getUserBlock in AbstractCheckUserPager

https://gerrit.wikimedia.org/r/1068791

gerritbot added a comment.Aug 30 2024, 8:23 PM

Change #1068799 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Hard deprecate GlobalBlocking::getUserBlock

https://gerrit.wikimedia.org/r/1068799

Dreamy_Jazz moved this task from Sprint Theremin (Aug 26 - Sept. 6) to Sprint Beatboxing (Sept 16-27) on the Trust and Safety Product Sprint board.Sep 16 2024, 10:10 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)); removed Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.
kostajh moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 16 2024, 7:23 PM
gerritbot added a comment.Sep 16 2024, 7:52 PM

Change #1068797 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Replace removed globalblocking blocked text message keys

https://gerrit.wikimedia.org/r/1068797

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.23; 2024-09-17); removed MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 16 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 16 2024, 8:30 PM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.Sep 21 2024, 4:55 AM
Djackson-ctr subscribed.

QA has been completed, and the new code change(s) are functioning as expected.

Dreamy_Jazz closed this task as Resolved.Sep 23 2024, 1:31 PM
Dreamy_Jazz updated the task description. (Show Details)Jan 24 2025, 1:55 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJan 24 2025, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits