Allow maxLength changes for json schema compatibility
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	cjming
	Aug 29 2024, 7:12 PM

Description

When updating schema versions, allow for changes to maxLength of a field in CI.

Example: https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/1068832 fails CI due to backward compatibility error:
https://integration.wikimedia.org/ci/job/generic-node18/482/console

11:39:19   1 failing
11:39:19 
11:39:19   1) Schema Compatibility in Repository ./jsonschema/
11:39:19        fragment/analytics/product_metrics/common
11:39:19          Major Version 1
11:39:19            1.1.2 must be compatible with 1.1.1:
11:39:19 
11:39:19       AssertionError [ERR_ASSERTION]: Error at path: .properties.action_context.maxLength
11:39:19       + expected - actual
11:39:19 
11:39:19       -8192
11:39:19       +64
11:39:19       
11:39:19       at new AssertionError (node:internal/assert/assertion_error:452:5)
11:39:19       at assertCompatible (node_modules/@wikimedia/jsonschema-tools/lib/tests/compatibility.js:98:15)
11:39:19       at assertCompatible (node_modules/@wikimedia/jsonschema-tools/lib/tests/compatibility.js:92:25)
11:39:19       at assertCompatible (node_modules/@wikimedia/jsonschema-tools/lib/tests/compatibility.js:92:25)
11:39:19       at assertCompatible (node_modules/@wikimedia/jsonschema-tools/lib/tests/compatibility.js:92:25)
11:39:19       at Context.<anonymous> (node_modules/@wikimedia/jsonschema-tools/lib/tests/compatibility.js:135:41)
11:39:19       at process.processImmediate (node:internal/timers:476:21)