FlaggedRevs new info dialog Review button opens target in new tab. This is not convenient.
Please open target in same tab and let browser actions to decide the target.
Task related to T191156: Convert FlaggedRevisions to Codex
Description
Description
Details
Details
Related Changes in Gerrit:
Related Objects
Related Objects
Event Timeline
Comment Actions
Change #1069208 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):
[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsHTML: make "review" button act more like a link
Comment Actions
Change #1069208 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsHTML: make "review" button open in same tab
Comment Actions
<Button> within <a> was perfect. Thanks to @Tacsipacsi we cannot open it in new tab. What was your problem with button within a? It is the recommended method.
Comment Actions
I don't see why this was reopened - what's described in the task title is fixed, thus task status is resolved.
Comment Actions
Could you ask please for clarification before closing? Only half of the problem is resolved. It had a perfect solution. Then Tacsipacsi came.
Comment Actions
Change #1071157 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):
[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsHTML: replace "Review..." <button> with <a>
Comment Actions
@Bean49: Please see https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette , especially Criticise ideas, not people. Thanks!
Comment Actions
To be clear, it never was a ‘button within a’. It had onclick="" event with window.open() method. Then the patch changed it to window.location.href. The patch above would make it the actual link because of T374028: FlaggedRevs review status popup buttons do not use correct semantics. I am closing this task because of this (since the issue in this task is resolved and the issue of opening the link in new tab will be resolved in T374028).
Comment Actions
@stjn: Please see patch history and first patchset. https://gerrit.wikimedia.org/r/1069208
Comment Actions
Yes, the first patchset shows that FR extension never had an <a> element. It had a <button> element that opened the link in a new tab via JS, preventing people from opening it in the same tab. It is an extremely bad way to code a link, but that is going to be addressed in T374028 (and after that a link could be opened however people would want).
<button> within <a> is also invalid HTML anyway.
Comment Actions
Change #1071157 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] FlaggedRevsHTML: replace "Review..." <button> with <a>
Comment Actions
To be clear, I asked for the <button> to be removed (completely replaced by the <a>), which I think we can agree to be the perfect solution. @Novem_Linguae couldn’t find out how to do that at the time, which is how we’ve came back to the <button>-only solution. Not perfect, but at least semantically meaningful. Fortunately, @Novem_Linguae figured out in the meantime how to do it with an <a> only, so we should have that perfect solution with the next release train (Thursday 19 September on Wikipedia).
I’d also like to make it clear that I’m not the person who broke it. I asked/proposed something. The patch author found that reasonable and so implemented it. Two reviewers said it’s okay (one +1 and one +2). That’s four people, not only me.