Page MenuHomePhabricator

Special:CreateProperty / log message after property creation (2.4.2)
Closed, ResolvedPublic

Description

Currently you get a log message upon creating a new property via Special:CreateProperty, e.g. "Created page with "This is a property of type Has type::Boolean."" with a link to Has type::Boolean. Instead of just displaying the contents of the new page it should say "Created a property of type Boolean." whilste Boolean links to Special:Types/Boolean for better usability of the log message.


Version: unspecified
Severity: enhancement

Details

Reference
bz35370

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:19 AM
bzimport set Reference to bz35370.

Actually this functionality is part of the SF extension. Reassigning now.

Change 118806 had a related patch set uploaded by Pawanseerwani:
Appropriate log message for property creation

https://gerrit.wikimedia.org/r/118806

pawanseerwani+bugzilla wrote:

This bug is quite interesting! :)

The log *seems* to be generated by Special:CreateProperty which is a part of SemanticForms(SF), but actually is generated in ContentHandler::getAutosummary() (includes/content/ContentHandler.php - line 736) which is a part of Mediawiki-core. So I think the component part of this bug should be changed to MW-Core.

Anyways, I have submitted the patch, and invite you to review.

Change 118973 had a related patch set uploaded by Pawanseerwani:
Appropriate log message for property creation

https://gerrit.wikimedia.org/r/118973

Change 118806 abandoned by Pawanseerwani:
Appropriate log message for property creation

Reason:
Should be edited in SF(Semantic Forms instead)

https://gerrit.wikimedia.org/r/118806

Change 118973 merged by jenkins-bot:
Appropriate log message for property creation

https://gerrit.wikimedia.org/r/118973

That's great. It is nice to see this improvement. Thank you!

Change 119315 had a related patch set uploaded by Pawanseerwani:
Appropriate log message for property creation

https://gerrit.wikimedia.org/r/119315

Change 119315 merged by jenkins-bot:
Appropriate log message for property creation

https://gerrit.wikimedia.org/r/119315

Hope that I am not prematurely closing this again. This is getting better by the minute. :)