Page MenuHomePhabricator
Create Task
Maniphest T373720

Deprecate use of CodeMirror 5
Closed, ResolvedPublic
Actions

Description

This task outlines the planned deprecation process for CodeMirror 5.

Checklist
  • Emit warning for use of CM5 on a CM6-enabled wiki (r1069290)
  • Deprecate and emit warning for use of the WikiEditor-specific ext.CodeMirror.switch hook (r1123812, depends on r1109533)
  • Replace old modules with .v6 ones and add .v6 aliases, with the latter marked as deprecated
  • Remove .v6 modules by MW 1.47 or even sooner

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
styles: clean up styles for CodeMirror 5Bhsdmediawiki/extensions/CodeMirrormaster+16 -53
ext.math.editpage: update CodeMirror RL moduleMusikAnimalmediawiki/extensions/Mathwmf/1.46.0-wmf.24+1 -1
Promote CM6 out of beta, remove CM5 modules, and add v6 aliasesMusikAnimalmediawiki/extensions/CodeMirrorwmf/1.46.0-wmf.24+465 -17 K
Promote CM6 out of beta, remove CM5 modules, and add v6 aliasesMusikAnimalmediawiki/extensions/CodeMirrormaster+465 -17 K
ext.math.editpage: update CodeMirror RL moduleMusikAnimalmediawiki/extensions/Mathmaster+1 -1
CM5: add more aggressive warnings about CM5 deprecationMusikAnimalmediawiki/extensions/CodeMirrorwmf/1.46.0-wmf.20+31 -5
CM5: add more aggressive warnings about CM5 deprecationMusikAnimalmediawiki/extensions/CodeMirrormaster+31 -5
Remove unused CM5 ResourceLoader modules deprecated in MW 1.44MusikAnimalmediawiki/extensions/CodeMirrormaster+1 -3 K
CodeMirror: bubble keyup, keydown and scroll events to the textareaMusikAnimalmediawiki/extensions/CodeMirrormaster+83 -23
CodeMirrorWikiEditor: add deprecation msg to ext.CodeMirror.switch hookMusikAnimalmediawiki/extensions/CodeMirrormaster+5 -1
CodeMirror: finalize stable interface for consumption by integrationsMusikAnimalmediawiki/extensions/CodeMirrormaster+755 -389
extension.json: add CM6 modes for JS, CSS, and JSON; deprecate CM5 modesMusikAnimalmediawiki/extensions/CodeMirrormaster+11 K -31
ext.CodeMirror.js: emit deprecation warning when using CM5 on CM6 wikiMusikAnimalmediawiki/extensions/CodeMirrormaster+9 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a project: Community-Tech. · View Herald TranscriptAug 30 2024, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MusikAnimal added a parent task: T259059: Upgrade to CodeMirror 6.Aug 30 2024, 9:45 PM
MusikAnimal mentioned this in T259059: Upgrade to CodeMirror 6.
gerritbot added a comment.Aug 30 2024, 9:50 PM

Change #1069290 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] ext.CodeMirror.js: emit deprecation warning when using CM5 on CM6 wiki

https://gerrit.wikimedia.org/r/1069290

gerritbot added a project: Patch-For-Review.Aug 30 2024, 9:51 PM
MusikAnimal updated the task description. (Show Details)Aug 30 2024, 9:51 PM
Izno subscribed.Aug 31 2024, 12:31 AM
gerritbot added a comment.Aug 31 2024, 6:03 AM

Change #1069290 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] ext.CodeMirror.js: emit deprecation warning when using CM5 on CM6 wiki

https://gerrit.wikimedia.org/r/1069290

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2024, 6:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 31 2024, 7:00 AM
MusikAnimal updated the task description. (Show Details)Sep 2 2024, 10:40 PM
MusikAnimal updated the task description. (Show Details)Nov 25 2024, 1:28 AM
MusikAnimal mentioned this in T357794: Update CodeMirror integrations in preparation for CodeMirror 6 upgrade.Dec 12 2024, 10:47 PM
MusikAnimal updated the task description. (Show Details)Jan 11 2025, 3:53 AM
gerritbot added a comment.Jan 11 2025, 8:28 AM

Change #1108354 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirror: move toggling logic to parent class, add life cycle methods

https://gerrit.wikimedia.org/r/1108354

gerritbot added a project: Patch-For-Review.Jan 11 2025, 8:28 AM
MusikAnimal moved this task from Backlog to CodeMirror 6 migration on the MediaWiki-extensions-CodeMirror board.Jan 14 2025, 12:40 AM
gerritbot added a comment.Jan 26 2025, 9:59 AM

Change #1114126 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] extension.json: rm unused CM5 modules, deprecate xml/htmlmixed/php modes

https://gerrit.wikimedia.org/r/1114126

gerritbot added a comment.Jan 29 2025, 3:14 PM

Change #1114126 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] extension.json: add CM6 modes for JS, CSS, and JSON; deprecate CM5 modes

https://gerrit.wikimedia.org/r/1114126

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 29 2025, 4:00 PM
gerritbot added a comment.Feb 22 2025, 10:36 AM

Change #1108354 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: finalize stable interface for consumption by integrations

https://gerrit.wikimedia.org/r/1108354

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2025, 11:30 AM
gerritbot added a comment.Mar 3 2025, 12:40 AM

Change #1123812 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: add deprecation msg to ext.CodeMirror.toggle hook

https://gerrit.wikimedia.org/r/1123812

gerritbot added a project: Patch-For-Review.Mar 3 2025, 12:40 AM
MusikAnimal updated the task description. (Show Details)Mar 3 2025, 2:25 AM
gerritbot added a comment.Mar 8 2025, 10:36 AM

Change #1123812 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorWikiEditor: add deprecation msg to ext.CodeMirror.switch hook

https://gerrit.wikimedia.org/r/1123812

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11); removed: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Mar 8 2025, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 8 2025, 11:30 AM
MusikAnimal updated the task description. (Show Details)Mar 20 2025, 8:37 PM
gerritbot added a comment.Apr 1 2025, 5:37 AM

Change #1129024 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirror: bubble keyup, keydown and scroll events to the textarea

https://gerrit.wikimedia.org/r/1129024

gerritbot added a project: Patch-For-Review.Apr 1 2025, 5:37 AM
gerritbot added a comment.Apr 2 2025, 12:49 AM

Change #1129024 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: bubble keyup, keydown and scroll events to the textarea

https://gerrit.wikimedia.org/r/1129024

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Apr 2 2025, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 2 2025, 1:30 AM
gerritbot added a comment.Jul 15 2025, 3:39 AM

Change #1169280 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] Remove unused CM5 ResourceLoader modules deprecated in MW 1.44

https://gerrit.wikimedia.org/r/1169280

gerritbot added a project: Patch-For-Review.Jul 15 2025, 3:39 AM
gerritbot added a comment.Jul 15 2025, 4:44 AM

Change #1169280 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Remove unused CM5 ResourceLoader modules deprecated in MW 1.44

https://gerrit.wikimedia.org/r/1169280

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2025, 5:31 AM
MusikAnimal updated the task description. (Show Details)Jul 20 2025, 10:17 PM
Mr._Starfleet_Command subscribed.Dec 13 2025, 7:06 PM
MusikAnimal updated the task description. (Show Details)Mar 8 2026, 4:10 AM
gerritbot added a comment.Mar 13 2026, 5:49 AM

Change #1251213 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CM5: add more aggressive warnings about CM5 deprecation

https://gerrit.wikimedia.org/r/1251213

gerritbot added a project: Patch-For-Review.Mar 13 2026, 5:49 AM
gerritbot added a comment.Mar 18 2026, 2:22 AM

Change #1251213 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CM5: add more aggressive warnings about CM5 deprecation

https://gerrit.wikimedia.org/r/1251213

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2026, 2:32 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 18 2026, 3:00 AM
gerritbot added a comment.Mar 18 2026, 3:01 AM

Change #1254468 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@wmf/1.46.0-wmf.20] CM5: add more aggressive warnings about CM5 deprecation

https://gerrit.wikimedia.org/r/1254468

gerritbot added a project: Patch-For-Review.Mar 18 2026, 3:01 AM
gerritbot added a comment.Mar 18 2026, 3:08 AM

Change #1254468 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@wmf/1.46.0-wmf.20] CM5: add more aggressive warnings about CM5 deprecation

https://gerrit.wikimedia.org/r/1254468

Stashbot added a comment.Mar 18 2026, 3:09 AM

Mentioned in SAL (#wikimedia-operations) [2026-03-18T03:09:46Z] <musikanimal@deploy2002> Started scap sync-world: Backport for [[gerrit:1254468|CM5: add more aggressive warnings about CM5 deprecation (T373720)]]

Stashbot added a comment.Mar 18 2026, 3:11 AM

Mentioned in SAL (#wikimedia-operations) [2026-03-18T03:11:49Z] <musikanimal@deploy2002> musikanimal: Backport for [[gerrit:1254468|CM5: add more aggressive warnings about CM5 deprecation (T373720)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Mar 18 2026, 3:22 AM

Mentioned in SAL (#wikimedia-operations) [2026-03-18T03:22:09Z] <musikanimal@deploy2002> Finished scap sync-world: Backport for [[gerrit:1254468|CM5: add more aggressive warnings about CM5 deprecation (T373720)]] (duration: 12m 22s)

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2026, 3:30 AM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 18 2026, 4:01 AM
gerritbot added a comment.Apr 14 2026, 11:50 PM

Change #1271092 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] Promote CM6 out of beta, remove CM5 modules, and add v6 aliases

https://gerrit.wikimedia.org/r/1271092

gerritbot added a project: Patch-For-Review.Apr 14 2026, 11:50 PM
gerritbot added a comment.Apr 14 2026, 11:59 PM

Change #1271100 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/Math@master] ext.math.editpage: update CodeMirror RL module

https://gerrit.wikimedia.org/r/1271100

Bhsd subscribed.EditedApr 15 2026, 6:37 AM

I find another extension that has hard dependency on the legacy CodeMirror 5 modules: MediaWiki-extensions-TEI

Edited: This extension seems to have been broken anyway, so it does not matter.

Bhsd mentioned this in T422565: Add button and keyboard shortcut to sort lines of text.Apr 15 2026, 5:24 PM
gerritbot added a comment.Apr 15 2026, 7:43 PM

Change #1271092 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Promote CM6 out of beta, remove CM5 modules, and add v6 aliases

https://gerrit.wikimedia.org/r/1271092

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28); removed: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Apr 15 2026, 8:00 PM
MusikAnimal closed this task as Resolved.Apr 15 2026, 8:37 PM
MusikAnimal claimed this task.
MusikAnimal updated the task description. (Show Details)
MusikAnimal moved this task from CodeMirror 6 migration to Done on the MediaWiki-extensions-CodeMirror board.
gerritbot added a comment.Apr 15 2026, 9:48 PM

Change #1271100 merged by jenkins-bot:

[mediawiki/extensions/Math@master] ext.math.editpage: update CodeMirror RL module

https://gerrit.wikimedia.org/r/1271100

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2026, 10:31 PM
NguoiDungKhongDinhDanh subscribed.Apr 16 2026, 11:29 AM

@MusikAnimal I see v6 modules have been renamed. Does this affect user scripts and gadgets? If it does, then when will the change be deployed? There are quite a few scripts that would need updating.

Mr._Starfleet_Command added a comment.Apr 16 2026, 2:11 PM

@NguoiDungKhongDinhDanh:

In T259059#11822688, @MusikAnimal wrote:

[...] [T]here are only ~25 instances of the v6 modules being used on-wiki, so I can fix those manually as a global interface editor. [...]

gerritbot added a comment.Apr 21 2026, 6:18 PM

Change #1275997 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@wmf/1.46.0-wmf.24] Promote CM6 out of beta, remove CM5 modules, and add v6 aliases

https://gerrit.wikimedia.org/r/1275997

gerritbot added a project: Patch-For-Review.Apr 21 2026, 6:18 PM
gerritbot added a comment.Apr 21 2026, 6:21 PM

Change #1276000 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/Math@wmf/1.46.0-wmf.24] ext.math.editpage: update CodeMirror RL module

https://gerrit.wikimedia.org/r/1276000

gerritbot added a comment.Apr 21 2026, 9:48 PM

Change #1275997 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@wmf/1.46.0-wmf.24] Promote CM6 out of beta, remove CM5 modules, and add v6 aliases

https://gerrit.wikimedia.org/r/1275997

gerritbot added a comment.Apr 21 2026, 9:56 PM

Change #1276000 merged by jenkins-bot:

[mediawiki/extensions/Math@wmf/1.46.0-wmf.24] ext.math.editpage: update CodeMirror RL module

https://gerrit.wikimedia.org/r/1276000

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 21 2026, 10:00 PM
Stashbot mentioned this in T419332: Replacing CodeEditor with CodeMirror by MW 1.46.Apr 21 2026, 10:02 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-21T22:02:08Z] <musikanimal@deploy1003> Started scap sync-world: Backport for [[gerrit:1275997|Promote CM6 out of beta, remove CM5 modules, and add v6 aliases (T373720)]], [[gerrit:1276002|VisualEditor.CodeMirror.less: remove CM5 styles]], [[gerrit:1276004|CodeEditorHooks: remove temporary code for CodeMirror beta feature (T419332)]], [[gerrit:1276005|DescriptionField: use new module name for loading CodeMirror]], [[gerrit:1275998|Ho

Stashbot added a comment.Apr 21 2026, 10:19 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-21T22:18:58Z] <musikanimal@deploy1003> musikanimal: Backport for [[gerrit:1275997|Promote CM6 out of beta, remove CM5 modules, and add v6 aliases (T373720)]], [[gerrit:1276002|VisualEditor.CodeMirror.less: remove CM5 styles]], [[gerrit:1276004|CodeEditorHooks: remove temporary code for CodeMirror beta feature (T419332)]], [[gerrit:1276005|DescriptionField: use new module name for loading CodeMirror]], [[gerrit:1275998|Hooks: remove

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2026, 10:34 PM
Stashbot added a comment.Apr 21 2026, 10:37 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-21T22:37:25Z] <musikanimal@deploy1003> Finished scap sync-world: Backport for [[gerrit:1275997|Promote CM6 out of beta, remove CM5 modules, and add v6 aliases (T373720)]], [[gerrit:1276002|VisualEditor.CodeMirror.less: remove CM5 styles]], [[gerrit:1276004|CodeEditorHooks: remove temporary code for CodeMirror beta feature (T419332)]], [[gerrit:1276005|DescriptionField: use new module name for loading CodeMirror]], [[gerrit:1275998|H

MusikAnimal added a comment.Apr 21 2026, 10:56 PM

I could not update these pages due to hCaptcha being broken, or something:

kostajh subscribed.Apr 24 2026, 11:05 AM
In T373720#11847751, @MusikAnimal wrote:

I could not update these pages due to hCaptcha being broken, or something:

@MusikAnimal could you please clarify what error(s) you encountered?

MusikAnimal added a comment.Apr 24 2026, 5:06 PM
In T373720#11854915, @kostajh wrote:

@MusikAnimal could you please clarify what error(s) you encountered?

Sorry I wasn't more specific at the time; I felt rushed as this was in the midst of a deployment. Trying again just now, everything seemed to work just fine :)

To my recollection:

  • I made the same changes as just now
  • Clicked "Show changes" to make the "Publish changes" button active (which I think is a gadget or something on zhwiki)
  • Clicking on "Publish changes" did noting at all; No user-facing errors. I thought it was a bug with the aforementioned "must preview first" script, so:
  • I ran $('#editform').submit() from the JS console to try to get around it
  • The form apparently submitted and the page refreshed, but no changes were saved, and again no user-facing errors
  • The JS console showed a bunch of errors related to hCAPTCHA, hence my conclusion

I also noticed this report on enwiki VPT which sounded very similar to my experience. They apparently had something blocking hCAPTCHA. I did not (all JS was permitted on my end). It's possible one of my privacy-related browser extensions was at fault, but I didn't change anything and I was able to make the same edit today without issue.

I do recall however upon initial visit, I was not logged into zhwiki. I clicked "Login" and the SUL did its thing, and I was logged in. The fact I had the ability to edit this JS at all proves I was logged in, but anyway, maybe the fact that I had only recently logged in had something to do with it? Just a guess.

gerritbot added a comment.Apr 25 2026, 5:42 PM

Change #1277239 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] styles: clean up styles for CodeMirror 5

https://gerrit.wikimedia.org/r/1277239

gerritbot added a project: Patch-For-Review.Apr 25 2026, 5:42 PM
gerritbot added a comment.Apr 26 2026, 4:29 AM

Change #1277239 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] styles: clean up styles for CodeMirror 5

https://gerrit.wikimedia.org/r/1277239

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2026, 4:30 AM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28); removed: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 26 2026, 5:00 AM
Bugreporter2 awarded a token.Jul 5 2026, 12:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits