Page MenuHomePhabricator

action=watch is broken for interface-protected pages
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Don't be an interface administrator on enwiki
  2. Go to https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadgets-definition&action=watch (works for any page which requires "editsitecss, editsitejs" permissions to edit)
    1. Regular users might end up here, if they open the link of the watchlist star icon in a new browser tab (middle mouse click, Ctrl+click, etc), or if they click the icon (or press the corresponding accesskey) sooner than JS code for handling the watchlist icon clicks without page loads is loaded.
    2. Another example: https://en.wikipedia.org/wiki/User:Ahecht/Scripts/refresh.js?action=watch

What happens?:

Permission error
This interface message or skin forms part of the MediaWiki interface. It may be documented on MediaWiki.org or translatewiki.net.
Only administrators and interface editors can editmywatchlist it. You can submit an edit request by clicking the button below and following the instructions.

(emphasis mine)

The error comes from:

What should have happened instead?:

A form should load:

Update watchlist

Watchlist time period:
Permanent ⌵
Watch

This can be seen for other pages, even sysop-protected, like https://en.wikipedia.org/w/index.php?title=Main_Page&action=watch

Other information (browser name/version, screenshots, etc.):

action=unwatch is also affected:

Details

Related Changes in Gerrit:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1069706 had a related patch set uploaded (by Wargo; author: Wargo):

[mediawiki/core@master] Allow (un)watch restricted pages

https://gerrit.wikimedia.org/r/1069706

@Ammarpad you left comment on my commit. I think my patch fixes all errors mentioned there. Do you think some is not? If yes, how to test (reproduce) them?

@Ammarpad are your suggestions still actual?

Please discuss the code on Gerrit. What needs to be tested is already there

Change #1069706 merged by jenkins-bot:

[mediawiki/core@master] Allow (un)watch restricted pages

https://gerrit.wikimedia.org/r/1069706

matmarex subscribed.

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).

I'm confused, because the commit that fixed this issue is listed at https://www.mediawiki.org/wiki/MediaWiki_1.44/wmf.11/Changelog, quote:

git #28005560 - Allow (un)watch restricted pages (T373758) by Wargo

Which version is correct 1.44.0-wmf.12 or 1.44.0-wmf.11? Which bot is correct – ReleaseTaggerBot here at Phabricator or User:ReleaseNotesBot at mediawiki.org?

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).

I'm confused, because the commit that fixed this issue is listed at https://www.mediawiki.org/wiki/MediaWiki_1.44/wmf.11/Changelog, quote:

git #28005560 - Allow (un)watch restricted pages (T373758) by Wargo

Which version is correct 1.44.0-wmf.12 or 1.44.0-wmf.11? Which bot is correct – ReleaseTaggerBot here at Phabricator or User:ReleaseNotesBot at mediawiki.org?

wmf.11 is correct.

Some deployments around December-January are always cancelled due to the holidays, and sometimes someone forgets to update one of the calendars that should be in sync. Or perhaps the maintainers were on holidays themselves. :)