Page MenuHomePhabricator

echo notifications badge icon is misaligned vertically on vector when lang is ky
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Log on
  • Set interface language to ky
  • Set skin to vector
  • Look at the bell icon on the top of the screen

Example url: https://commons.wikimedia.org/wiki/Special:Watchlist?useskin=vector&uselang=ky&safemode=1

What happens?:

  • The bell icon is vertically misaligned from the rest of the row

What should have happened instead?:

  • The bell icon should be vertically misaligned with the rest of the row

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (66×398 px, 5 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova subscribed.

Thank you, @Xaosflux for filing the issue!

The issue is reproducible on FF 129 (Chrome 128 seems to be fine) and is specific to vector legacy skin (not specific to commons, for example, testwiki wmf.21 displays the issue) :

Screen Shot 2024-09-04 at 3.35.51 PM.png (468×1 px, 78 KB)

To reproduce the issue - switch to ky lang via ULS or add uselang=ky (as per the task description). No other languages (that I tried) do not trigger the issue - I tried uz, kk, tr (similar lang to ky), el, de, gu and ru.

matmarex claimed this task.
matmarex added subscribers: Jdlrobson, matmarex.

This was caused by a typo in translation, fixed in this change: https://translatewiki.net/w/i.php?title=MediaWiki:Echo-notification-alert/ky&diff=prev&oldid=13085062

The typo resulted in the accessibility label for that icon being empty, which caused the <span> element that contains it not to be generated, which caused the incorrect appearance (even though the element is invisible).

Thanks @matmarex ! (sorry forgot to post my draft!)

In https://en.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&uselang=ky&useskin=vector no span element has been output because https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Echo-notification-alert/ky is incorrect syntax (I think). It is {{PLURAL:$1|$1 кабарлама||100=99+ кабарлама}} not {{PLURAL:$1|$1 кабарлама|100=99+ кабарлама}} notice the double pipe.

Echo should probably handle this better and/or the translatewiki entry should be updated.

I fixed it on translatewiki:
https://translatewiki.net/w/i.php?title=Special%3ATranslate&showMessage=echo-notification-alert&group=ext-echo-interface&language=ky&action_source=search&filter=&optional=1&action=translate
So that should at least resolve this issue when the translations get updated.