We got a report on IRC:
lucaswerkmeister> hi! I randomly noticed today that l10n-bot pushed a new twn branch for the wd-image-positions-tool a few days ago (https://gitlab.wikimedia.org/toolforge-repos/wd-image-positions/-/tree/twn?ref_type=heads) but seemingly didn’t create a merge request for it
I suspect this is because the GitLab token has expired.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | abi_ | T373807 L10n-bot did not create a GitLab merge request | |||
| Resolved | abi_ | T378483 Investigate why WikiLearn translation exports are failing with merge conflicts |
This is still happening, by the way, which means the Wikidata Image Positions translations are now over a month outdated :/
I think the PR is failing to get created due to the failing CI
See:
as examples. The failures are caused by:
FAILED i18n/ar.json::check_message_variables[index-paragraph-2] - AssertionError: assert (('{' + 'url_wikidata') + '!h:') in 'بالنسبة للبيانات الخاصة بعناصر [ {url_wikidata} ويكي بيانات]، تُعرض على العنصر {P18} (أو خاصية أخرى). بالنسبة للبيانات الخاصة بملفات {url_sdoc!h:بيانات منظمة على كومنز}، تُعرض على الملف نفسه.'
FAILED i18n/ar.json::check_message_html_elements[alert-not-logged-in] - AssertionError: assert 'style' in {'dir', 'lang'}
FAILED i18n/ar.json::check_message_variables[alert-not-logged-in] - assert (('{' + 'url') + '!h:') in 'لم تسجل الدخول<noscript style=";text-align:right;direction:rtl"> وقد عُطل جافا سكريبت</noscript>، لذا يمكنك فقط عرض ا... المناطق الموجودة، [ {url} سجل الدخول]<noscript style=";text-align:right;direction:rtl"> وفعل جافا سكريبت</noscript> .'
======================== 3 failed, 3278 passed in 4.00s ========================
make: *** [Makefile:5: check] Error 1
Cleaning up project directory and file based variables
ERROR: Job failed: command terminated with exit code 1The related messages are here:
That’s not how it worked in the past – https://gitlab.wikimedia.org/toolforge-repos/wd-image-positions/-/merge_requests/4 was initially created with CI errors according to the comments. And then I got a notification about the merge request, saw the CI errors, and fixed them. Without the merge request, that’s not going to happen, so if this is an intentional change, I’d like to revert it: a workflow where l10n-bot doesn’t create merge requests with failing CI doesn’t work for me at all.
Thanks. Niklas was right. I regenerated the access token and I think that fixed it. Created a PR here by manually running the exports: https://gitlab.wikimedia.org/toolforge-repos/wd-image-positions/-/merge_requests/20
Lets see if this works on Thursday during the automated export.
Alright, thanks – I’ve updated the translations on TWN now, so we should hopefully see some changes on Thursday.
Mentioned in SAL (#wikimedia-cloud) [2024-10-11T17:29:42Z] <wmbot~lucaswerkmeister@tools-bastion-13> deployed f6af6d59e6 (l10n updates: ar, ca, el, es, it, sv, uk; had been broken for a while due to T373807)
Mentioned in SAL (#wikimedia-cloud) [2024-10-13T11:28:35Z] <wmbot~lucaswerkmeister@tools-bastion-13> deployed a4d0774ea2 (upgrade dependencies, including MarkupSafe 3.0); also deploys f6af6d59e6 (l10n updates: ar, ca, el, es, it, sv, uk; had been broken for a while due to T373807) which I previously accidentally “deployed” and logged in quickcategories instead, oops :D
It’s happening again. https://gitlab.wikimedia.org/toolforge-repos/wd-image-positions/-/tree/twn?ref_type=heads currently has green CI, yet no merge request was created.
Mentioned in SAL (#wikimedia-cloud) [2024-11-05T18:30:10Z] <wmbot~lucaswerkmeister@tools-bastion-13> deployed 33511f4de7 (l10n updates: it, lb, sr-ec, zh-hans, zh-hant; had been blocked by T373807)