local.tf-test@lima-kilo:~$ toolforge webservice php7.4 shell -- ls Flag --wait has been deprecated, because it is not used by this command. It will be removed in version 1.29.
Description
Description
Details
Details
Related Changes in GitLab:
| Title | Reference | Author | Source Branch | Dest Branch | |
|---|---|---|---|---|---|
| d/changelog: bump to 0.103.11 | repos/cloud/toolforge/webservice-cli!56 | sstefanova | bump_to_0.103.11 | main | |
| shell: drop --wait | repos/cloud/toolforge/webservice-cli!55 | lucaswerkmeister | no-wait | main | |
| shell: drop --wait | repos/cloud/toolforge/webservice-cli!54 | lucaswerkmeister | no-wait | main |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T408785 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.33 | |||
| Open | None | T379047 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.32 | |||
| Open | taavi | T372697 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.31 | |||
| Open | None | T335131 [infra,k8s] replace admission controllers with an existing policy admin project | |||
| Open | None | T364293 [infra,k8s] Move to kubernetes VAPs and drop kyverno | |||
| Resolved | dcaro | T362869 [k8s,infra] Upgrade Toolforge to Uwubernetes (1.30) | |||
| Resolved | fnegri | T362868 [infra,k8s] Upgrade Toolforge Kubernetes to version 1.29 | |||
| Resolved | Slst2020 | T373866 [infra, k8s, webservice] remove deprecated kubectl --wait flag before k8s 1.29 upgrade |
Event Timeline
Comment Actions
FWIW, according to the commit deprecating this and other flags, --wait had no effect (since at least 1.26, which is the version we’re running), so it should be safe to just remove. (I haven’t been able to find any old documentation that would tell us whether it used to do something or not, but if the --wait was ever needed for something then it probably already broke whenever an older k8s version made the flag have no effect.)
Comment Actions
(Kubernetes 1.31 apparently adds a --wait option again but who knows if it does the same thing.)
Comment Actions
I guess so :P since I already started looking into this after noticing the output (I’m guessing it’s due to the Kubernetes upgrade yesterday?)
Comment Actions
lucaswerkmeister opened https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/54
shell: drop --wait
Comment Actions
thanks @LucasWerkmeister!
you know... if you want to be part of the k8s upgrades workgroup... just say the word :))
there's the mythical Uwubernetes upgrade... •⩊•
Comment Actions
lucaswerkmeister opened https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/55
shell: drop --wait
Comment Actions
lucaswerkmeister closed https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/54
shell: drop --wait
Comment Actions
lucaswerkmeister merged https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/55
shell: drop --wait
Comment Actions
sstefanova opened https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/56
d/changelog: bump to 0.103.11
Comment Actions
sstefanova merged https://gitlab.wikimedia.org/repos/cloud/toolforge/tools-webservice/-/merge_requests/56
d/changelog: bump to 0.103.11
Comment Actions
The warning still appears, by the way – I guess someone™ still needs to deploy the new version? (I might technically have the required permissions but wouldn’t know how to do it…)
Comment Actions
Heh, I think I'm that someone. What happened is that Toolsbeta was in disarray for a while during the last k8s upgrade, so I postponed testing and deploying the MR, and then promptly forgot 🙈
Comment Actions
This deployment seems to still be pending.
tools.schedule-deployment@tools-bastion-12:~$ webservice shell Flag --wait has been deprecated, because it is not used by this command. It will be removed in version 1.29.
Comment Actions
Still happening after the 1.28 upgrade today:
tools-bastion-12:~$ webservice shell Flag --wait has been deprecated, because it is not used by this command. It will be removed in version 1.29.
Comment Actions
done – the deprecation warning is gone now.
tools.automated-toolforge-tests@tools-bastion-12:~$ webservice shell tools.automated-toolforge-tests@shell-1730880334:~$