There's misalignment in the 2010 wiktiext editor toolbar too, possibly due to the embeeded OOUI buttons on the right:

Other apps that may be affected by this:

• DiscussionTools
  • Same as VE, all UI is scaled with the content size
• ContentTranslation
  • Appears to not respect the font size setting at all, so not affected in the same way currently (cc @santhosh)
• GrowthExperiments (cc @Urbanecm_WMF)

DT example (note how the [edit source] UI component doesn't change size):

In T373875#10116683, @Esanders wrote:

• GrowthExperiments (cc @Urbanecm_WMF)

Thanks for the ping, flagged in team chat, so that we can take a look at how this affects us.

Change #1070896 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Use fixed font size for UI componenets in Vector 22

https://gerrit.wikimedia.org/r/1070896

Change #1070896 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use fixed font size for UI componenets in Vector 22

https://gerrit.wikimedia.org/r/1070896

Change #1071203 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Use fixed font size for UI componenets in Vector 22

https://gerrit.wikimedia.org/r/1071203

Change #1071212 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Use UI font size for mw-teleport-target

https://gerrit.wikimedia.org/r/1071212

Change #1071203 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use fixed font size for UI components in Vector 22

https://gerrit.wikimedia.org/r/1071203

Change #1071212 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use UI font size for mw-teleport-target

https://gerrit.wikimedia.org/r/1071212

I don't think there are upstream changes needed here. The fix is to not apply font scaling to interface components in the content area. Unless you plan to start scaling interface components?

In T373875#10129301, @Esanders wrote:

I don't think there are upstream changes needed here. The fix is to not apply font scaling to interface components in the content area. Unless you plan to start scaling interface components?

Okay, I might be misunderstanding what happened here. You're right that the intention is not to scale the interface with the font size preference for now (that's open for discussion in T370549). I think there were still some concerns from DST around use of hardcoded font size values and mw-teleport-target styles. Maybe @egardner can provide some more info.

The .mw-teleport-target applies to Codex dialogs so Codex dialogs are also impacted by this change (I just confirmed this on the dark mode opt in banner overlay - it is now appearing with smaller font sizes).

Change #1072249 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Use base font size for wikitext editors

https://gerrit.wikimedia.org/r/1072249

Change #1072250 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Disable font size scaling on Special: pages

https://gerrit.wikimedia.org/r/1072250

Change #1072249 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use base font size for wikitext editors

https://gerrit.wikimedia.org/r/1072249

Change #1072250 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Disable font size scaling on Special: pages, and other namespaces

https://gerrit.wikimedia.org/r/1072250

In T373875#10130197, @CCiufo-WMF wrote:

In T373875#10129301, @Esanders wrote:

I don't think there are upstream changes needed here. The fix is to not apply font scaling to interface components in the content area. Unless you plan to start scaling interface components?

Okay, I might be misunderstanding what happened here. You're right that the intention is not to scale the interface with the font size preference for now (that's open for discussion in T370549). I think there were still some concerns from DST around use of hardcoded font size values and mw-teleport-target styles. Maybe @egardner can provide some more info.

@Esanders's patch to style the #mw-teleport-target actually restores the styles that I initially added when I first introduced this element (see T343476 for context). I guess they got removed at some point?

But yes, this feature is used by both OOUI and Codex, and the expected behavior may not be the same in all cases.

In VE, it sounds like OOUI toolbar elements (which should receive the interface font size) are being rendered inside #mw-teleport-target. But I introduced this element to serve a different use-case originally – I wanted Codex dialogs which got launched from the content of a page (like a SpecialPage dashboard UI) to inherit the content font size so that they match their surroundings.

Since this code was originally written, Vector has rolled out user-customizable font sizes, and the distinction between content font sizes (which can change based on user pref) vs interface font sizes (which don't change due to user pref but may change due to skin) has emerged.

Anyway, we will probably need to revisit this once we have a better solution for how to manage all the different font size combinations. I'm hoping that we can leverage CSS variables in a way similar to how we did for dark mode, where we have a small number of font-size tokens whose values can be overridden by skin and/or user pref. But we may still need to account for differences between "interface" and "content" font size if that distinction is going to persist.

In VE, it sounds like OOUI toolbar elements (which should receive the interface font size) are being rendered inside #mw-teleport-target.

Not just VE -- all OOUI dialogs go in the teleport target as-of T348286. It was recommended in T339058#9201151 that it be used as a standard place for overlays, to get away from Vector's changes that were interfering with dialogs.

Also, the toolbars are a separate thing. They're not in the teleport target (unless they're in a dialog that's in the teleport target, which can happen).

@DLynch what do you call the pop-up widgets like "Edit Link" in VE? This was the element that was being rendered in #mw-teleport-target and being improperly sized right?

@egardner that's an inspector (or a context item, which renders very similarly). It's not in the teleport target, though, just in the area affected by content styles like the rest of VE. The only things we put in the teleport target are modal dialogs (e.g. the insert-a-template dialog, the save dialog, etc).

Since the fix hasn't made it out to group2 yet, you can see it affecting a dialog in the teleport target in this screenshot from enwiki:

In T373875#10138364, @gerritbot wrote:

Change #1072249 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use base font size for wikitext editors

https://gerrit.wikimedia.org/r/1072249

For reference, this was the 2010 wikitext editor before this fix:

Change #1073264 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/skins/Vector@master] Teleport target font-size override should be on the ID

https://gerrit.wikimedia.org/r/1073264

(I think because when I reviewed the previous teleport patch, the thing I checked that was in the teleport-target had already been fixed by one of the other VE fixes. Oops.)

Change #1073264 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Teleport target font-size override should be on the ID

https://gerrit.wikimedia.org/r/1073264