Page MenuHomePhabricator
Create Task
Maniphest T373920

TypeError: MediaWiki\Parser\ParserOutput::setNumericPageProperty with non-numeric value
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: MediaWiki\Parser\ParserOutput::setNumericPageProperty with non-numeric value
exception.trace
from /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/ParserOutput.php(1583)
#0 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/ParserOutput.php(2555): MediaWiki\Parser\ParserOutput->setNumericPageProperty(string, bool)
#1 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/Parsoid/Config/DataAccess.php(371): MediaWiki\Parser\ParserOutput->collectMetadata(MediaWiki\Parser\ParserOutput)
#2 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Utils/PipelineUtils.php(686): MediaWiki\Parser\Parsoid\Config\DataAccess->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\ParserOutput, string)
#3 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(150): Wikimedia\Parsoid\Utils\PipelineUtils::fetchHTML(Wikimedia\Parsoid\Config\Env, string)
#4 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(273): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onExtension(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#5 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(138): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#6 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(113): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#7 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(166): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#8 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(132): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->process(array, array)
#9 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Utils/PipelineUtils.php(107): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parse(string, array)
#10 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(643): Wikimedia\Parsoid\Utils\PipelineUtils::processContentInPipeline(Wikimedia\Parsoid\Config\Env, Wikimedia\Parsoid\Wt2Html\PageConfigFrame, string, array)
#11 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1080): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->processTemplateSource(Wikimedia\Parsoid\Tokens\SelfclosingTagTk, array, string)
#12 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1110): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->expandTemplate(Wikimedia\Parsoid\Wt2Html\TT\TemplateEncapsulator)
#13 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1151): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTemplate(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#14 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(138): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#15 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(113): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#16 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(176): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#17 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(174): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#18 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TreeBuilder/TreeBuilderStage.php(476): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#19 [internal function]: Wikimedia\Parsoid\Wt2Html\TreeBuilder\TreeBuilderStage->processChunkily(string, array)
#20 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(985): Generator->current()
#21 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(172): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#22 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(287): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#23 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wikitext/ContentModelHandler.php(176): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#24 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Parsoid.php(197): Wikimedia\Parsoid\Wikitext\ContentModelHandler->toDOM(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, null)
#25 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Parsoid.php(240): Wikimedia\Parsoid\Parsoid->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\ParserOutput, array, null)
#26 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/Parsoid/ParsoidParser.php(134): Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array, null, MediaWiki\Parser\ParserOutput)
#27 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/Parsoid/ParsoidParser.php(248): MediaWiki\Parser\Parsoid\ParsoidParser->genParserOutput(MediaWiki\Parser\Parsoid\Config\PageConfig, ParserOptions, null)
#28 /srv/mediawiki/php-1.43.0-wmf.21/extensions/Linter/includes/LintUpdate.php(89): MediaWiki\Parser\Parsoid\ParsoidParser->parse(string, MediaWiki\Title\Title, ParserOptions, bool, bool, int)
#29 /srv/mediawiki/php-1.43.0-wmf.21/includes/deferred/DeferredUpdates.php(460): MediaWiki\Linter\LintUpdate->doUpdate()
#30 /srv/mediawiki/php-1.43.0-wmf.21/includes/deferred/RefreshSecondaryDataUpdate.php(112): MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Linter\LintUpdate)
#31 /srv/mediawiki/php-1.43.0-wmf.21/includes/deferred/DeferredUpdates.php(460): MediaWiki\Deferred\RefreshSecondaryDataUpdate->doUpdate()
#32 /srv/mediawiki/php-1.43.0-wmf.21/includes/Storage/DerivedPageDataUpdater.php(1833): MediaWiki\Deferred\DeferredUpdates::attemptUpdate(MediaWiki\Deferred\RefreshSecondaryDataUpdate)
#33 /srv/mediawiki/php-1.43.0-wmf.21/includes/page/WikiPage.php(1911): MediaWiki\Storage\DerivedPageDataUpdater->doSecondaryDataUpdates(array)
#34 /srv/mediawiki/php-1.43.0-wmf.21/includes/jobqueue/jobs/RefreshLinksJob.php(297): WikiPage->doSecondaryDataUpdates(array)
#35 /srv/mediawiki/php-1.43.0-wmf.21/includes/jobqueue/jobs/RefreshLinksJob.php(204): RefreshLinksJob->runForTitle(MediaWiki\Title\Title)
#36 /srv/mediawiki/php-1.43.0-wmf.21/extensions/EventBus/includes/JobExecutor.php(80): RefreshLinksJob->run()
#37 /srv/mediawiki/rpc/RunSingleJob.php(60): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#38 {main}
Notes

A burst of 319 of these happened after rolling 1.43.0-wmf.21 to group0 today.

Details

MediaWiki Version
1.43.0-wmf.21
Request URL
https://mw-jobrunner.discovery.wmnet/rpc/RunSingleJob.php
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ParserOutput::setNumericPageProperty: Add some detail to TypError, for easier debuggingJforrestermediawiki/coremaster+4 -1
ParserOutput::collectMetadata: Properly handle non-scalar page propertiesC. Scott Ananianmediawiki/coremaster+5 -4
ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatalJforrestermediawiki/coremaster+7 -3
ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatalHasharmediawiki/corewmf/1.43.0-wmf.21+7 -3
Revert "Add missing cases to ParserOutput::collectMetadata()"Jforrestermediawiki/coremaster+1 -37
Revert "Add missing cases to ParserOutput::collectMetadata()"Jforrestermediawiki/corewmf/1.43.0-wmf.21+1 -37
ParserOutput: collectMetadata: Handle non-string/non-numeric caseSubramanya Sastrymediawiki/coremaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

dancy created this task.Sep 3 2024, 6:20 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptSep 3 2024, 6:20 PM
dancy triaged this task as Unbreak Now! priority.Sep 3 2024, 6:22 PM
dancy added a parent task: T373640: 1.43.0-wmf.21 deployment blockers.
Jdforrester-WMF subscribed.Sep 3 2024, 6:54 PM

Error has been thrown since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1019302 which landed in April – this looks like it was caused by 550f916fa957f483b45c0feefb5740affb1f0405.

gerritbot added a comment.Sep 3 2024, 7:05 PM

Change #1070317 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ParserOutput::setNumericPageProperty: Add some detail to TypError, for easier debugging

https://gerrit.wikimedia.org/r/1070317

gerritbot added a project: Patch-For-Review.Sep 3 2024, 7:05 PM
gerritbot added a comment.Sep 3 2024, 7:09 PM

Change #1070318 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Revert "Add missing cases to ParserOutput::collectMetadata()"

https://gerrit.wikimedia.org/r/1070318

gerritbot added a comment.Sep 3 2024, 7:09 PM

Change #1070319 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@wmf/1.43.0-wmf.21] Revert "Add missing cases to ParserOutput::collectMetadata()"

https://gerrit.wikimedia.org/r/1070319

gerritbot added a comment.Sep 3 2024, 7:21 PM

Change #1070325 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] ParserOutput: collectMetadata: Handle non-string/non-numeric case

https://gerrit.wikimedia.org/r/1070325

gerritbot added a comment.Sep 3 2024, 7:21 PM

Change #1070326 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatal

https://gerrit.wikimedia.org/r/1070326

gerritbot added a comment.Sep 3 2024, 7:25 PM

Change #1070325 abandoned by Subramanya Sastry:

[mediawiki/core@master] ParserOutput: collectMetadata: Handle non-string/non-numeric case

Reason:

In favour of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070326

https://gerrit.wikimedia.org/r/1070325

gerritbot added a comment.Sep 3 2024, 7:51 PM

Change #1070326 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatal

https://gerrit.wikimedia.org/r/1070326

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 3 2024, 8:00 PM
gerritbot added a comment.Sep 4 2024, 9:34 AM

Change #1070319 abandoned by Hashar:

[mediawiki/core@wmf/1.43.0-wmf.21] Revert "Add missing cases to ParserOutput::collectMetadata()"

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070326

https://gerrit.wikimedia.org/r/1070319

gerritbot added a comment.Sep 4 2024, 9:35 AM

Change #1070318 abandoned by Hashar:

[mediawiki/core@master] Revert "Add missing cases to ParserOutput::collectMetadata()"

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070326

https://gerrit.wikimedia.org/r/1070318

gerritbot added a comment.Sep 4 2024, 9:38 AM

Change #1070548 had a related patch set uploaded (by Hashar; author: Jforrester):

[mediawiki/core@wmf/1.43.0-wmf.21] ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatal

https://gerrit.wikimedia.org/r/1070548

gerritbot added a comment.Sep 4 2024, 2:55 PM

Change #1070548 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.21] ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatal

https://gerrit.wikimedia.org/r/1070548

Stashbot added a comment.Sep 4 2024, 3:00 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T15:00:34Z] <hashar@deploy1003> Started scap sync-world: Backport for [[gerrit:1070548|ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatal (T373920)]]

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03); removed: MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 4 2024, 3:00 PM
Stashbot added a comment.Sep 4 2024, 3:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T15:04:22Z] <hashar@deploy1003> hashar: Backport for [[gerrit:1070548|ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatal (T373920)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

• hashar mentioned this in T373640: 1.43.0-wmf.21 deployment blockers.Sep 4 2024, 3:08 PM
Stashbot added a comment.Sep 4 2024, 3:09 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T15:09:11Z] <hashar@deploy1003> Finished scap sync-world: Backport for [[gerrit:1070548|ParserOutput::collectMetadata: Log if given value is non-numeric and also non-string, for easier debugging, and don't fatal (T373920)]] (duration: 08m 37s)

• Agusbou2015 subscribed.Sep 4 2024, 3:23 PM
dancy mentioned this in T374046: PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa.Sep 4 2024, 5:49 PM
gerritbot added a comment.Sep 4 2024, 7:07 PM

Change #1070660 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput::collectMetadata: Properly handle non-scalar page properties

https://gerrit.wikimedia.org/r/1070660

cscott subscribed.Sep 4 2024, 7:25 PM

Advice for train conductors in T374046#10119288:

This is a long way of saying that you can probably cherry pick just 1070658 to quiet the logs and leave the "more correct" 1070660 to ride next week's train.

gerritbot added a comment.Sep 5 2024, 7:30 PM

Change #1070660 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput::collectMetadata: Properly handle non-scalar page properties

https://gerrit.wikimedia.org/r/1070660

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 5 2024, 8:00 PM
• thcipriani lowered the priority of this task from Unbreak Now! to Needs Triage.Sep 6 2024, 4:37 PM
• thcipriani subscribed.
In T373920#10119292, @cscott wrote:

Advice for train conductors in T374046#10119288:

This is a long way of saying that you can probably cherry pick just 1070658 to quiet the logs and leave the "more correct" 1070660 to ride next week's train.

Ack, thanks. Removing from train blockers and resetting priority.

• thcipriani removed a parent task: T373640: 1.43.0-wmf.21 deployment blockers.Sep 6 2024, 4:37 PM
Krinkle added projects: MediaWiki-Parser, Content-Transform-Team.Oct 10 2024, 3:37 PM
Krinkle moved this task from Untriaged to Oct 2024 on the Wikimedia-production-error board.Oct 10 2024, 3:51 PM
MSantos edited projects, added: Content-Transform-Team-WIP; removed: Content-Transform-Team.Oct 31 2024, 2:26 PM
MSantos added a project: Essential-Work.
MSantos moved this task from Backlog to To Verify on the Content-Transform-Team-WIP board.
Pppery edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Dec 17 2024, 3:31 AM
ABreault-WMF closed this task as Resolved.Apr 8 2025, 6:55 PM
ABreault-WMF assigned this task to cscott.
gerritbot added a comment.Mar 30 2026, 1:19 PM

Change #1070317 abandoned by Hashar:

[mediawiki/core@master] ParserOutput::setNumericPageProperty: Add some detail to TypError, for easier debugging

https://gerrit.wikimedia.org/r/1070317

gerritbot added a comment.Mar 30 2026, 11:08 PM

Change #1070317 restored by Thcipriani:

[mediawiki/core@master] ParserOutput::setNumericPageProperty: Add some detail to TypError, for easier debugging

https://gerrit.wikimedia.org/r/1070317

gerritbot added a project: Patch-For-Review.Mar 30 2026, 11:08 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptMar 30 2026, 11:08 PM
Pppery edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Mar 31 2026, 2:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits