Page MenuHomePhabricator
Create Task
Maniphest T374010

Create IP /Temp account sheet component, present from Article
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
GOlson-WMF
Authored By
Tsevener
Sep 4 2024, 1:59 PM
Project Tags
Referenced Files
F59291768: IMG_0285 (1).PNG
Apr 18 2025, 7:43 PM
F59291767: image (19).png
Apr 18 2025, 7:43 PM
Subscribers
ABorbaWMF
Aklapper
ARamirez_WMF
cmadeo
Dbrant
HNordeenWMF
JTannerWMF
View All 15 Subscribers

Description

  • When user is about to enter the article editor, get their auth status.
  • Create a new sheet component. Allow it to be configured with image and copy for both IP users ("You are not logged in") and temporary account users ("You are using a temporary account".). See the "You are not logged in" and "You are using a temporary account" UI modal component in T337250 for reference.
  • Present modal component created in step 2 before they enter the editor, IF their auth state from step 1 indicates ip or temporary. Configure it to IP or Temporary state.
  • The area that presents the editor is here - ArticleViewController's presentEditor method. We can try to modify this method to present the new component.

Test notes:
Either using IP or Temporary Accounts, or switching the statement
Navigate to an article
Press edit
Ensure pop up shows up, repeat with other type of account

Experimental Build 238

Related Objects
Search...

Event Timeline

Tsevener created this task.Sep 4 2024, 1:59 PM
Tsevener renamed this task from [M] Create Temp account sheet component to [M] Create IP /Temp account sheet component.
Tsevener mentioned this in T374012: Update navigation bar.
Seddon moved this task from iOS Release FY2024-25 to Needs Triage on the Wikipedia-iOS-App board.Sep 5 2024, 1:08 PM
Seddon edited projects, added: Wikipedia-iOS-App; removed: Wikipedia-iOS-App (iOS Release FY2024-25).
Seddon triaged this task as Low priority.Sep 6 2024, 2:08 PM
Seddon moved this task from Needs Triage to Up next on the Wikipedia-iOS-App board.
kostajh moved this task from Inbox to Needs Other Teams on the Temporary accounts board.Sep 10 2024, 11:55 AM
GOlson-WMF moved this task from Up next to iOS Release FY2024-25 on the Wikipedia-iOS-App board.Nov 26 2024, 7:10 PM
GOlson-WMF edited projects, added: Wikipedia-iOS-App (iOS Release FY2024-25); removed: Wikipedia-iOS-App.
GOlson-WMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App (iOS Release FY2024-25) board.
Tsevener updated the task description. (Show Details)Dec 2 2024, 10:03 PM
Tsevener mentioned this in T340790: [M] Temporary Accounts on iOS: Title description editing.Dec 19 2024, 4:48 PM
Tsevener mentioned this in T337268: Temporary Accounts on iOS: Talk .Dec 19 2024, 4:52 PM
HNordeenWMF mentioned this in T373067: [Epic] Temporary Accounts on iOS.Dec 19 2024, 10:16 PM
HNordeenWMF moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Dec 19 2024, 10:23 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptDec 19 2024, 10:23 PM
HNordeenWMF raised the priority of this task from Low to Medium.Dec 19 2024, 10:23 PM
HNordeenWMF moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Jan 7 2025, 6:42 PM
Tsevener updated the task description. (Show Details)Jan 7 2025, 10:35 PM
Seddon added a project: iOS Sprint 2025: Bellach.Jan 8 2025, 5:05 PM
Seddon set the point value for this task to 3.Jan 8 2025, 7:03 PM
HNordeenWMF removed a project: iOS Sprint 2025: Bellach.Jan 9 2025, 8:50 PM
HNordeenWMF moved this task from Current Sprint Work to Ready for future sprints on the Wikipedia-iOS-App (iOS Release FY2024-25) board.
Tsevener moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Jan 9 2025, 11:29 PM
HNordeenWMF added a project: iOS Sprint 2025: Bellach.Jan 10 2025, 12:22 AM
GOlson-WMF claimed this task.Jan 17 2025, 3:06 PM
GOlson-WMF moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App (iOS Release FY2024-25) board.
GOlson-WMF moved this task from Doing to Ready for future sprints on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Jan 21 2025, 11:52 PM
HNordeenWMF lowered the priority of this task from Medium to Low.Jan 24 2025, 6:01 PM
GOlson-WMF moved this task from Ready for future sprints to Doing on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Jan 24 2025, 8:24 PM
Seddon renamed this task from [M] Create IP /Temp account sheet component to Create IP /Temp account sheet component.Jan 27 2025, 1:35 PM
Mazevedo added a project: iOS Sprint 2025: Cairo.Jan 27 2025, 5:25 PM
GOlson-WMF moved this task from Doing to Blocked or Waiting on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Jan 29 2025, 6:29 PM

Waiting on URLs

GOlson-WMF added a comment.Jan 29 2025, 7:33 PM

Update from Robin: change X buttons -> Done in upper lefthand corner to match

GitHubPRBot added a comment.Jan 29 2025, 8:09 PM

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5176

GOlson-WMF moved this task from Blocked or Waiting to Needs Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Jan 30 2025, 4:09 PM
GOlson-WMF moved this task from Needs Code Review to Doing on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 3 2025, 7:31 PM
GOlson-WMF moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 3 2025, 9:12 PM
GOlson-WMF moved this task from Needs Code Review to Doing on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 3 2025, 9:16 PM
Mazevedo added a project: iOS Sprint 2025: Didcot.Feb 4 2025, 7:02 PM
Tsevener renamed this task from Create IP /Temp account sheet component to Create IP /Temp account sheet component, present from Article.Feb 5 2025, 2:24 PM
Tsevener updated the task description. (Show Details)
GOlson-WMF moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 5 2025, 6:10 PM
Tsevener moved this task from Needs Code Review to Did not pass Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 5 2025, 7:22 PM
GOlson-WMF moved this task from Did not pass Code Review to Needs Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 6 2025, 3:27 PM
Tsevener moved this task from Needs Code Review to Did not pass Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 6 2025, 9:38 PM
GOlson-WMF moved this task from Did not pass Code Review to Design signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.EditedFeb 7 2025, 2:27 AM

@scblr

Build:
Experimental (Black logo) Build 221

GitHubPRBot added a comment.Feb 7 2025, 4:46 PM

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5176

Tsevener added a project: iOS Sprint 2025: Egypt.Feb 18 2025, 11:28 PM
• scblr moved this task from Design signoff to Needs Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 24 2025, 11:17 AM
• scblr moved this task from Needs Code Review to Design signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.
GOlson-WMF moved this task from Design signoff to Did not pass design review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 25 2025, 3:26 PM
GOlson-WMF moved this task from Did not pass design review to Needs Code Review on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Mar 3 2025, 3:29 PM

Design change in https://phabricator.wikimedia.org/T337519

Dreamy_Jazz moved this task from Inbox to Tracking work by others on the Trust and Safety Product Team board.Mar 4 2025, 4:40 PM
Tsevener moved this task from Needs Code Review to Blocked or Waiting on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Mar 4 2025, 9:51 PM

This is ready to QA. Moving to Blocked / Waiting since it's hanging out in a feature branch (temp-accounts) until all temp accounts work is done.

GOlson-WMF moved this task from Blocked or Waiting to Needs QA signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Mar 20 2025, 1:45 PM
GOlson-WMF added a comment.Mar 20 2025, 1:49 PM

Experimental build 236

GOlson-WMF updated the task description. (Show Details)Mar 20 2025, 2:09 PM
ABorbaWMF moved this task from Needs QA signoff to Did not pass QA on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Mar 21 2025, 4:25 PM
ABorbaWMF subscribed.

Testing on 7.7.3.236

When logged out and attempting to edit, I am seeing the temp sheet, but tapping continue without logging in does nothing.

GOlson-WMF moved this task from Did not pass QA to Blocked or Waiting on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Mar 21 2025, 5:04 PM
GOlson-WMF moved this task from Blocked or Waiting to Needs QA signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Mar 28 2025, 6:12 PM
Tsevener updated the task description. (Show Details)Mar 28 2025, 10:12 PM
Tsevener updated the task description. (Show Details)Mar 28 2025, 10:17 PM

Experimental Build 238

GOlson-WMF moved this task from Needs QA signoff to Needs Testing Criteria on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Apr 1 2025, 5:13 PM
GOlson-WMF moved this task from Needs Testing Criteria to Needs QA signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Apr 4 2025, 5:28 PM
ABorbaWMF moved this task from Needs QA signoff to Ready for PM Signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Apr 16 2025, 3:09 AM

Looks good on 7.7.3 (5140)

HNordeenWMF subscribed.Apr 18 2025, 12:22 AM

Looks good to me!

The screen presented on first tap into editor is correct. The one presented from article view (red icon in top left) matches that one. According to the designs it should be slightly different, but it has the same functionality, so it's fine by me that they're the same (and @GOlson-WMF I feel like we agreed on this a while back!)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Apr 18 2025, 12:22 AM
HNordeenWMF moved this task from Ready for Release to Did not pass QA on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Apr 18 2025, 7:43 PM

I’m never seeing the illustration for this screen in all the places it’s used ( Left is design, right is Beta) - could that be added in (in all places where the "You are using a temporary account" screen is used?

image (19).png (375×812 px, 33 KB)
IMG_0285 (1).PNG (1,179×2,556 px, 307 KB)
Tsevener moved this task from Did not pass QA to Ready for PM Signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Apr 18 2025, 8:35 PM
HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Apr 18 2025, 8:42 PM
HNordeenWMF closed this task as Resolved.Apr 24 2025, 9:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits