Page MenuHomePhabricator
Create Task
Maniphest T374012

Update navigation bar
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
GOlson-WMF
Authored By
Tsevener
Sep 4 2024, 2:00 PM
Tags
Referenced Files
F58476117: secondary-ctas.png
Feb 24 2025, 11:16 AM
F58426949: Simulator Screen Recording - iPhone 15 Pro - 2025-02-19 at 16.08.26.mp4
Feb 19 2025, 9:12 PM
F58426948: Simulator Screen Recording - iPhone 15 Pro - 2025-02-19 at 15.59.21.mp4
Feb 19 2025, 9:12 PM
Subscribers
ABorbaWMF
Aklapper
ARamirez_WMF
cmadeo
Dbrant
JTannerWMF
Niharika
View All 14 Subscribers

Description

  • Reference https://github.com/wikimedia/wikipedia-ios/pull/5176 for how to pull an accurate auth state, as our approach changed a lot in PR review for that.
  • If auth state indicates ip or temporary, add new button with expected icon to navigation bar in editor. Present sheet from T374010 upon tap
  • (If needed) Update edit notices icon to orange.

Test Steps

Using a temporary account, Test language
Navigate to article
Press pencil button (unlocked)
Make sure temporary account sheet shows, press Done
Ensure the temporary account icon shows, tap it
Ensure temporary account sheet shows
Repeat steps with IP account

Experimental Build 238

Related Objects
Search...

Event Timeline

Tsevener created this task.Sep 4 2024, 2:00 PM
Seddon moved this task from iOS Release FY2024-25 to Needs Triage on the Wikipedia-iOS-App-Backlog board.Sep 5 2024, 1:08 PM
Seddon edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (iOS Release FY2024-25).
Seddon triaged this task as Low priority.Sep 6 2024, 2:07 PM
Seddon moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.
kostajh moved this task from Inbox to Needs Other Teams on the Temporary accounts board.Sep 10 2024, 11:55 AM
GOlson-WMF moved this task from Up next to iOS Release FY2024-25 on the Wikipedia-iOS-App-Backlog board.Nov 26 2024, 7:10 PM
GOlson-WMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.
GOlson-WMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
Tsevener updated the task description. (Show Details)Dec 2 2024, 10:05 PM
Tsevener updated the task description. (Show Details)Dec 2 2024, 10:14 PM
Tsevener updated the task description. (Show Details)
HNordeenWMF mentioned this in T373067: [Epic] Temporary Accounts on iOS.Dec 19 2024, 10:16 PM
HNordeenWMF raised the priority of this task from Low to Medium.Dec 19 2024, 10:22 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptDec 19 2024, 10:22 PM
HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (iOS Release FY2024-25).Dec 19 2024, 10:28 PM
HNordeenWMF moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.Dec 19 2024, 10:30 PM
Seddon renamed this task from [S] Update navigation bar to Update navigation bar.Jan 27 2025, 1:30 PM
Seddon set the point value for this task to 1.
HNordeenWMF lowered the priority of this task from Medium to Low.Jan 27 2025, 6:24 PM
HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.
HNordeenWMF moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
GOlson-WMF claimed this task.Feb 3 2025, 2:55 PM
GOlson-WMF moved this task from Ready for future sprints to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
GOlson-WMF moved this task from Doing to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 4 2025, 3:54 PM
Mazevedo moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 4 2025, 6:27 PM
Mazevedo added a project: iOS Sprint 2025: Didcot.Feb 4 2025, 7:01 PM
Tsevener updated the task description. (Show Details)Feb 5 2025, 7:21 PM
GOlson-WMF moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 7 2025, 8:01 PM
Tsevener added a project: iOS Sprint 2025: Egypt.Feb 18 2025, 11:28 PM
GitHubPRBot added a comment.Feb 19 2025, 9:11 PM

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5204

GOlson-WMF updated the task description. (Show Details)Feb 19 2025, 9:11 PM

Simulator Screen Recording - iPhone 15 Pro - 2025-02-19 at 15.59.21.mp41 MBDownload

Simulator Screen Recording - iPhone 15 Pro - 2025-02-19 at 16.08.26.mp42 MBDownload

@scblr - the navigation bar in total is different but outside the scope of this particular ticket, but here are videos of the sheets and notices!

GOlson-WMF moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 19 2025, 9:12 PM
• scblr added a comment.Feb 24 2025, 11:16 AM

Hey @GOlson-WMF – this mostly looks good – the secondary CTA’s could be moved slightly up, though (~ 8px). See the comparison below.

Design (first screen) vs Implementation (second and third screen):

secondary-ctas.png (1×2 px, 584 KB)

After this minor tweak, there’s no need to design review again – thanks!

GOlson-WMF mentioned this in T337519: [M] Temporary Accounts on iOS: Log in and create account.Mar 3 2025, 3:29 PM
Tsevener moved this task from Needs Code Review to Did not pass Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Mar 3 2025, 8:23 PM
Dreamy_Jazz moved this task from Inbox to Tracking work by others on the Trust and Safety Product Team board.Mar 4 2025, 4:05 PM
Tsevener moved this task from Did not pass Code Review to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Mar 4 2025, 9:51 PM

This is ready to QA. Moving to Blocked / Waiting since it's hanging out in a feature branch (temp-accounts) until all temp accounts work is done.

GOlson-WMF moved this task from Blocked or Waiting to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Mar 20 2025, 1:45 PM

Experimental build 236

GOlson-WMF moved this task from Needs QA signoff to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Mar 21 2025, 5:03 PM
Tsevener moved this task from Needs Code Review to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Mar 21 2025, 7:20 PM
GOlson-WMF moved this task from Blocked or Waiting to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Mar 28 2025, 6:12 PM
Tsevener updated the task description. (Show Details)Mar 28 2025, 10:12 PM
Tsevener added a comment.Mar 28 2025, 10:16 PM

Experimental Build 238

GOlson-WMF moved this task from Needs QA signoff to Needs Testing Criteria on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Apr 1 2025, 5:13 PM
GOlson-WMF moved this task from Needs Testing Criteria to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Apr 4 2025, 5:28 PM
ABorbaWMF moved this task from Needs QA signoff to Ready for PM Signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Apr 16 2025, 3:11 AM
ABorbaWMF subscribed.

Works for me on 7.7.3 (5140)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Apr 18 2025, 5:32 PM
HNordeenWMF closed this task as Resolved.Apr 24 2025, 9:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits