Current HTML code of default FlaggedRevs review status popup has multiple accessibility issues.
Example link here: https://uk.wikipedia.org/wiki/Лідихівка (but you need review permissions to show all the buttons)
Review link
- Review...
<button class="cdx-button cdx-button--action-progressive cdx-button--weight-primary cdx-button--size-medium cdx-dialog__footer__primary-action" onclick="window.open(' //ru.wikipedia.org/w/index.php?title=%D0%97%D0%B0%D0%B3%D0%BB%D0%B0%D0%B2%D0%BD%D0%B0%D1%8F_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D0%B0&diff=cur&oldid=138627140 ');" type="submit">Review...</button>This is a semantically unacceptable way to create a link. The button should be modified to actually represent a link, if this is technically possible. If this is not technically possible, Codex should be improved to make it technically possible.
Other buttons
- X
<button class="cdx-button cdx-button--action-default cdx-button--weight-quiet cdx-button--size-medium cdx-button--icon-only cdx-dialog__header__close-button" aria-label="Close" onclick="document.getElementById("mw-fr-revision-details").style.display = "none";" type="submit"><span class="cdx-icon cdx-icon--medium cdx-fr-css-icon--close"></span></button>
- Cancel
<button class="cdx-dialog__footer__default-action cdx-button cdx-button--default" onclick="document.getElementById("mw-fr-revision-details").style.display = "none";" type="submit">Cancel</button>
These buttons should not have type="submit" since they don’t actually submit anything. The appropriate button type in this case is type="button".
I should also note that using onclick="" is an incredibly hacky way to write JS code that should ideally be avoided.
cc @Dogu as the person responsible