Page MenuHomePhabricator
Create Task
Maniphest T374046

PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', set '1' (T373920) [Called from MediaWiki\Parser\ParserOutput::collectMetadata in /srv/mediawiki/php-1.43.0-wmf.21/includes/pa
exception.trace
from /srv/mediawiki/php-1.43.0-wmf.21/includes/debug/MWDebug.php(498)
#0 [internal function]: MWExceptionHandler::handleError(int, string, string, int, array)
#1 /srv/mediawiki/php-1.43.0-wmf.21/includes/debug/MWDebug.php(498): trigger_error(string, int)
#2 /srv/mediawiki/php-1.43.0-wmf.21/includes/debug/MWDebug.php(209): MediaWiki\Debug\MWDebug::sendMessage(string, string, int)
#3 /srv/mediawiki/php-1.43.0-wmf.21/includes/GlobalFunctions.php(832): MediaWiki\Debug\MWDebug::warning(string, int, int, string)
#4 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/ParserOutput.php(2557): wfLogWarning(string)
#5 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/Parsoid/Config/DataAccess.php(371): MediaWiki\Parser\ParserOutput->collectMetadata(MediaWiki\Parser\ParserOutput)
#6 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Utils/PipelineUtils.php(686): MediaWiki\Parser\Parsoid\Config\DataAccess->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\ParserOutput, string)
#7 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(150): Wikimedia\Parsoid\Utils\PipelineUtils::fetchHTML(Wikimedia\Parsoid\Config\Env, string)
#8 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(273): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onExtension(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#9 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(138): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#10 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(113): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#11 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(166): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#12 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(132): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->process(array, array)
#13 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Utils/PipelineUtils.php(107): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parse(string, array)
#14 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(643): Wikimedia\Parsoid\Utils\PipelineUtils::processContentInPipeline(Wikimedia\Parsoid\Config\Env, Wikimedia\Parsoid\Wt2Html\PageConfigFrame, string, array)
#15 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1080): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->processTemplateSource(Wikimedia\Parsoid\Tokens\SelfclosingTagTk, array, string)
#16 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1110): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->expandTemplate(Wikimedia\Parsoid\Wt2Html\TT\TemplateEncapsulator)
#17 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TemplateHandler.php(1151): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTemplate(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#18 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(138): Wikimedia\Parsoid\Wt2Html\TT\TemplateHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#19 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(113): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#20 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(176): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#21 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(174): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#22 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/TreeBuilder/TreeBuilderStage.php(476): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#23 [internal function]: Wikimedia\Parsoid\Wt2Html\TreeBuilder\TreeBuilderStage->processChunkily(string, array)
#24 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(985): Generator->current()
#25 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(172): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#26 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(287): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#27 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Wikitext/ContentModelHandler.php(176): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#28 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Parsoid.php(197): Wikimedia\Parsoid\Wikitext\ContentModelHandler->toDOM(Wikimedia\Parsoid\Ext\ParsoidExtensionAPI, null)
#29 /srv/mediawiki/php-1.43.0-wmf.21/vendor/wikimedia/parsoid/src/Parsoid.php(240): Wikimedia\Parsoid\Parsoid->parseWikitext(MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\ParserOutput, array, null)
#30 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/Parsoid/ParsoidParser.php(134): Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array, null, MediaWiki\Parser\ParserOutput)
#31 /srv/mediawiki/php-1.43.0-wmf.21/includes/parser/Parsoid/ParsoidParser.php(248): MediaWiki\Parser\Parsoid\ParsoidParser->genParserOutput(MediaWiki\Parser\Parsoid\Config\PageConfig, ParserOptions, MediaWiki\Parser\ParserOutput)
#32 /srv/mediawiki/php-1.43.0-wmf.21/includes/content/WikitextContentHandler.php(384): MediaWiki\Parser\Parsoid\ParsoidParser->parse(string, MediaWiki\Title\Title, ParserOptions, bool, bool, int, MediaWiki\Parser\ParserOutput)
#33 /srv/mediawiki/php-1.43.0-wmf.21/includes/content/ContentHandler.php(1693): MediaWiki\Content\WikitextContentHandler->fillParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#34 /srv/mediawiki/php-1.43.0-wmf.21/includes/content/Renderer/ContentRenderer.php(79): MediaWiki\Content\ContentHandler->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#35 /srv/mediawiki/php-1.43.0-wmf.21/includes/Revision/RenderedRevision.php(262): MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Title\Title, MediaWiki\Revision\RevisionStoreRecord, ParserOptions, array)
#36 /srv/mediawiki/php-1.43.0-wmf.21/includes/Revision/RenderedRevision.php(234): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(MediaWiki\Content\WikitextContent, array)
#37 /srv/mediawiki/php-1.43.0-wmf.21/includes/Revision/RevisionRenderer.php(234): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#38 /srv/mediawiki/php-1.43.0-wmf.21/includes/Revision/RevisionRenderer.php(170): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, ParserOptions, array)
#39 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#40 /srv/mediawiki/php-1.43.0-wmf.21/includes/Revision/RenderedRevision.php(199): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#41 /srv/mediawiki/php-1.43.0-wmf.21/includes/poolcounter/PoolWorkArticleView.php(97): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#42 /srv/mediawiki/php-1.43.0-wmf.21/includes/poolcounter/PoolWorkArticleViewCurrent.php(114): MediaWiki\PoolCounter\PoolWorkArticleView->renderRevision(MediaWiki\Parser\ParserOutput)
#43 /srv/mediawiki/php-1.43.0-wmf.21/includes/poolcounter/PoolCounterWork.php(171): MediaWiki\PoolCounter\PoolWorkArticleViewCurrent->doWork()
#44 /srv/mediawiki/php-1.43.0-wmf.21/includes/page/ParserOutputAccess.php(358): MediaWiki\PoolCounter\PoolCounterWork->execute()
#45 /srv/mediawiki/php-1.43.0-wmf.21/includes/page/Article.php(826): MediaWiki\Page\ParserOutputAccess->getParserOutput(WikiPage, ParserOptions, MediaWiki\Revision\RevisionStoreRecord, int)
#46 /srv/mediawiki/php-1.43.0-wmf.21/includes/page/Article.php(545): Article->generateContentOutput(MediaWiki\User\User, ParserOptions, int, MediaWiki\Output\OutputPage, array)
#47 /srv/mediawiki/php-1.43.0-wmf.21/includes/actions/ViewAction.php(78): Article->view()
#48 /srv/mediawiki/php-1.43.0-wmf.21/includes/actions/ActionEntryPoint.php(731): ViewAction->show()
#49 /srv/mediawiki/php-1.43.0-wmf.21/includes/actions/ActionEntryPoint.php(508): MediaWiki\Actions\ActionEntryPoint->performAction(Article, MediaWiki\Title\Title)
#50 /srv/mediawiki/php-1.43.0-wmf.21/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#51 /srv/mediawiki/php-1.43.0-wmf.21/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#52 /srv/mediawiki/php-1.43.0-wmf.21/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#53 /srv/mediawiki/w/index.php(3): require(string)
#54 {main}
Impact
Notes

More than 7000 of these seen since rolling 1.43.0-wmf.21 to group0 today. It comes in big bursts. There are two variants:

  • MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-is-translation', ...
  • MediaWiki\Parser\ParserOutput::collectMetadata: bad type for 'translate-has-languages-tag', ...

Details

MediaWiki Version
1.43.0-wmf.21
Request URL
https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format/de
SubjectRepoBranchLines +/-
ParserOutput::collectMetadata: Properly handle non-scalar page propertiesmediawiki/coremaster+5 -4
Replace use of ParserOutput::setPageProperty, deprecated in 1.42mediawiki/extensions/Translatemaster+2 -2
ParserOutput: Turn off noisy log - we have the info we need for nowmediawiki/corewmf/1.43.0-wmf.21+3 -4
ParserOutput: Turn off noisy log - we have the info we need for nowmediawiki/coremaster+3 -4
Customize query in gerrit

Related Objects

Event Timeline

dancy triaged this task as Unbreak Now! priority.Sep 4 2024, 5:44 PM
dancy created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2024, 5:44 PM
dancy updated the task description. (Show Details)Sep 4 2024, 5:45 PM
dancy added a parent task: T373640: 1.43.0-wmf.21 deployment blockers.
IKhitron subscribed.Sep 4 2024, 5:48 PM
dancy added a comment.Sep 4 2024, 5:49 PM

Possibly related to T373920 ?

dancy mentioned this in T373640: 1.43.0-wmf.21 deployment blockers.Sep 4 2024, 5:51 PM
ssastry added subscribers: cscott, Jdforrester-WMF, ssastry.Sep 4 2024, 5:52 PM

Yes, these are warnings @Jdforrester-WMF logged yday (as part of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070326 ) to help us better fix the underlying issue -- the code works around it for now, but just is a noisy log. My recommendation is to filter out this warning and proceed. FYI. @cscott

ssastry added a comment.Sep 4 2024, 5:57 PM

Comes from https://codesearch.wmcloud.org/deployed/?q=is-translation&files=&excludeFiles=&repos= and as expected, it is a boolean value.

Agusbou2015 subscribed.Sep 4 2024, 5:58 PM
ssastry added a comment.Sep 4 2024, 6:02 PM

There is also https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2024.09.04?id=3VIgvpEBa-PL6vFem9kr for "translate-has-languages-tag" which has a very low frequency, but probably also a boolean from the translate extension.

thcipriani subscribed.Sep 4 2024, 6:32 PM
In T374046#10118982, @ssastry wrote:

Yes, these are warnings @Jdforrester-WMF logged yday (as part of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070326 ) to help us better fix the underlying issue -- the code works around it for now, but just is a noisy log. My recommendation is to filter out this warning and proceed. FYI. @cscott

Are you expecting this to still be useful for debugging? Otherwise my preference would be to remove it, makes a few dashboards hard to read and if it's served its purpose then it'd be nice to remove it.

gerritbot added a comment.Sep 4 2024, 6:43 PM

Change #1070658 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] ParserOutput: Turn off noisy log - we have the info we need for now

https://gerrit.wikimedia.org/r/1070658

gerritbot added a project: Patch-For-Review.Sep 4 2024, 6:43 PM
ssastry added a comment.Sep 4 2024, 6:44 PM

Yup, we have the info we need to fix caller sites and the patch above turns it off.

gerritbot added a comment.Sep 4 2024, 7:07 PM

Change #1070660 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput::collectMetadata: Properly handle non-scalar page properties

https://gerrit.wikimedia.org/r/1070660

gerritbot added a comment.Sep 4 2024, 7:18 PM

Change #1070658 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: Turn off noisy log - we have the info we need for now

https://gerrit.wikimedia.org/r/1070658

cscott added a comment.Sep 4 2024, 7:24 PM

Sorry, I was out yesterday and wasn't able to review, but https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1070660 is a better fix that avoids giving the wrong value for Parsoid's ParserOutput metadata -- ParserOutput from legacy called should (eg) represent false as false and not '' (which is the value you'd obtain from the implicit cast to string in ::setUnsortedPageProperty).

This difference barely matters at all in production because the LinksUpdate job is only using the legacy parser, which isn't going to use ParserOutput::collectMetadata() and thus is unaffected by T374046/T373920. The only real difference is going to be that Parsoid will think the page property value stored in the ParserOuput for false will be '' whereas the legacy parser would store it in the ParserOutput as boolean false (that value is then later converted to the string '0' in the database and the numeric value 0 as a sort key -- but those will be correct because they will still be coming from metadata generated by the legacy parser)

This is a long way of saying that you can probably cherry pick just 1070658 to quiet the logs and leave the "more correct" 1070660 to ride next week's train.

cscott mentioned this in T373920: TypeError: MediaWiki\Parser\ParserOutput::setNumericPageProperty with non-numeric value.Sep 4 2024, 7:25 PM
gerritbot added a comment.Sep 4 2024, 7:27 PM

Change #1070663 had a related patch set uploaded (by C. Scott Ananian; author: Subramanya Sastry):

[mediawiki/core@wmf/1.43.0-wmf.21] ParserOutput: Turn off noisy log - we have the info we need for now

https://gerrit.wikimedia.org/r/1070663

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 4 2024, 8:00 PM
gerritbot added a comment.Sep 4 2024, 8:16 PM

Change #1070663 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.21] ParserOutput: Turn off noisy log - we have the info we need for now

https://gerrit.wikimedia.org/r/1070663

Stashbot added a comment.Sep 4 2024, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T20:17:14Z] <dancy@deploy1003> Started scap sync-world: Backport for [[gerrit:1070663|ParserOutput: Turn off noisy log - we have the info we need for now (T374046)]]

Stashbot added a comment.Sep 4 2024, 8:19 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T20:19:21Z] <dancy@deploy1003> dancy, cscott: Backport for [[gerrit:1070663|ParserOutput: Turn off noisy log - we have the info we need for now (T374046)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Sep 4 2024, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-04T20:30:48Z] <dancy@deploy1003> Finished scap sync-world: Backport for [[gerrit:1070663|ParserOutput: Turn off noisy log - we have the info we need for now (T374046)]] (duration: 13m 33s)

gerritbot added a comment.Sep 4 2024, 8:36 PM

Change #1070666 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Translate@master] Replace use of ParserOutput::setPageProperty, deprecated in 1.42

https://gerrit.wikimedia.org/r/1070666

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.21; 2024-09-03); removed MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 4 2024, 9:00 PM
SLopes-WMF edited projects, added Content-Transform-Team-WIP; removed Parsoid.Sep 5 2024, 2:20 PM
SLopes-WMF moved this task from Backlog to To Verify on the Content-Transform-Team-WIP board.
gerritbot added a comment.Sep 5 2024, 7:29 PM

Change #1070666 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace use of ParserOutput::setPageProperty, deprecated in 1.42

https://gerrit.wikimedia.org/r/1070666

gerritbot added a comment.Sep 5 2024, 7:30 PM

Change #1070660 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput::collectMetadata: Properly handle non-scalar page properties

https://gerrit.wikimedia.org/r/1070660

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 5 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 5 2024, 8:30 PM
thcipriani moved this task from Untriaged to Sep 2024 on the Wikimedia-production-error board.Sep 6 2024, 4:32 PM
thcipriani lowered the priority of this task from Unbreak Now! to Needs Triage.Sep 6 2024, 4:36 PM
In T374046#10119288, @cscott wrote:

This is a long way of saying that you can probably cherry pick just 1070658 to quiet the logs and leave the "more correct" 1070660 to ride next week's train.

Ack, thanks. Removing from train blockers and resetting priority.

thcipriani removed a parent task: T373640: 1.43.0-wmf.21 deployment blockers.Sep 6 2024, 4:37 PM
MSantos added a project: Essential-Work.Sep 9 2024, 2:19 PM
cscott closed this task as Resolved.Sep 9 2024, 3:05 PM
cscott claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits