Page MenuHomePhabricator

Migrate GrowthExperiments.Mentorship Module to statslib
Closed, ResolvedPublic3 Estimated Story Points

Description

The Stats library (added in MW 1.41) attempts to better define the interface for generating metrics in MediaWiki. See Manual

As part of ensuring the whole of GrowthExperiments is using the Stats Library(Statslib) we should migrate the highlighted areas in GrowthExperiments.Mentorship

Please follow the guidelines and standards outlined in the provided documentation:

Acceptance Criteria
Update Affected Areas

  • MediaWiki.$wiki.GrowthExperiments.Mentorship.AutoMentors
  • MediaWiki.$wiki.GrowthExperiments.Mentorship.InactiveMentors
  • MediaWiki.$wiki.GrowthExperiments.Mentorship.NewcomerByMentors
  • MediaWiki.timing.growthExperiments.updateMenteeData.*.*.mean
  • MediaWiki.timing.growthExperiments.updateMenteeData.*.total.mean

Deploy and Verify changes

  • Deploy the changes to production.
  • Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
  • Verify that the changes have been successfully implemented(This is nothing complex besides normal functionality and metrics captured are sent to Prometheus are queried from in-use dashboards.)

Event Timeline

Was I subscribed here inadvertently?

@Micha_ Sorry for that, I meant to get @Michael. I'll unsubscribe you

DMburugu edited subscribers, added: Urbanecm_WMF; removed: Urbalazs.
Sgs triaged this task as High priority.Nov 18 2024, 3:14 PM
Sgs edited projects, added Growth-Team; removed Growth-Team (Maintenance).
Sgs moved this task to Maintenance on the Growth-Team board.
Sgs edited projects, added Growth-Team (Maintenance); removed Growth-Team.
Sgs set the point value for this task to 3.Nov 26 2024, 5:51 PM
Sgs moved this task from Maintenance to Current Sprint on the Growth-Team board.

Change #1102865 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] StatsLib: Migrate maintenance/UpdateMenteeData.php metrics to StatsLib

https://gerrit.wikimedia.org/r/1102865

Change #1102869 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] StatsLib: Convert periodic metrics collection system to StatsLib

https://gerrit.wikimedia.org/r/1102869

Patch has a -1 for a couple of days, moving back to Doing.

Change #1102865 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] StatsLib: Migrate maintenance/UpdateMenteeData.php metrics to StatsLib

https://gerrit.wikimedia.org/r/1102865

Change #1102869 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] StatsLib: Convert periodic metrics collection system to StatsLib

https://gerrit.wikimedia.org/r/1102869