Page MenuHomePhabricator
Create Task
Maniphest T374058

iOS schemas - add `is_temp` column for currently active MEP schemas
Closed, ResolvedPublic
Actions

Description

In preparation for the addition of Temporary Account data we will need to add a column, is_temp (boolean datatype) to currently active schemas to accommodate this data. (This change only needs to be made on MEP schemas as MP schemas already contain the performer.is_temp column).

SchemaColumn to adddatatypeStatus
ios_edit_history_compareis_tempbooleanTO DO
ios_navigation_eventsis_tempbooleanTO DO
ios_notification_interactionis_tempbooleanTO DO
ios_reading_listsis_tempbooleanTO DO
ios_searchis_tempbooleanTO DO
ios_setting_actionis_tempbooleanTO DO
ios_talk_page_interactionis_tempbooleanTO DO
ios_watchlistsis_tempbooleanTO DO
ios_edit_interactionis_tempbooleanTO DO
ios_login_actionis_tempbooleanTO DO
ios_user_historyis_tempbooleanTO DO
editattemptstepis_tempbooleanTO DO

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add is_temp field to iOS schema fragment.schemas/event/secondarymaster+2 K -89
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Add is_temp field to iOS schema fragment.repos/data-engineering/schemas-event-secondary!12dbrantios_is_tempmaster
Add is_temp field to iOS schema fragment.repos/data-engineering/schemas-event-secondary!3dbrantis_temp_iosmaster
Customize query in GitLab

Related Objects
Search...

Event Timeline

SNowick_WMF created this task.Sep 4 2024, 8:10 PM
SNowick_WMF mentioned this in T362283: [Spike] Audit Schemas in preparation for Temporary Accounts.Sep 4 2024, 8:56 PM
HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (iOS Release FY2024-25).Sep 4 2024, 10:51 PM
Seddon triaged this task as Low priority.Sep 10 2024, 5:28 PM
Seddon moved this task from Needs Triage to iOS Release FY2024-25 on the Wikipedia-iOS-App-Backlog board.
Seddon edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.
Seddon moved this task from Tasks from Product Backlog to Needs Analytics on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.
CodeReviewBot added a project: Patch-For-Review.Sep 12 2024, 1:46 PM

dbrant opened https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/3

Add is_temp field to iOS schema fragment.

Dbrant claimed this task.Sep 12 2024, 11:38 PM
HNordeenWMF moved this task from Needs Analytics to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 23 2024, 4:24 PM
gerritbot added a comment.Oct 3 2024, 3:35 PM

Change #1077742 had a related patch set uploaded (by Dbrant; author: Dbrant):

[schemas/event/secondary@master] Add is_temp field to iOS schema fragment.

https://gerrit.wikimedia.org/r/1077742

CodeReviewBot added a comment.Oct 3 2024, 4:52 PM

dbrant closed https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/3

Add is_temp field to iOS schema fragment.

Tsevener mentioned this in T376403: [S] Send is_temp boolean in for all MEP events.Oct 3 2024, 4:57 PM
CodeReviewBot added a comment.Oct 9 2024, 1:50 PM

dbrant opened https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/12

Add is_temp field to iOS schema fragment.

CodeReviewBot added a comment.Oct 9 2024, 1:59 PM

gmodena merged https://gitlab.wikimedia.org/repos/data-engineering/schemas-event-secondary/-/merge_requests/12

Add is_temp field to iOS schema fragment.

Dbrant added a comment.Oct 9 2024, 2:57 PM

@Tsevener This is now merged and deployed!
Each of the schemas mentioned in the task description gets a version bump of +1 in the minor version.
The is_temp field is technically optional (necessary for backwards compatibility), but can now be sent to any of the above schemas.

Tsevener moved this task from Needs Code Review to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 15 2024, 1:20 PM

This will be tested as a part of T376403.

SNowick_WMF updated the task description. (Show Details)Oct 21 2024, 6:23 PM
HNordeenWMF closed this task as Resolved.Oct 26 2024, 12:12 AM
HNordeenWMF removed Dbrant as the assignee of this task.
SNowick_WMF closed subtask T377749: Data validation for iOS schemas - is_temp as Resolved.Nov 26 2024, 10:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits