At the moment, I cannot reproduce this locally. The reuse tab stays disabled when I try it. The beta cluster is unreachable as of now, unfortunately.

I added this to our sprint and will try again tomorrow. Thanks a lot for bringing this to our attention! Luckily it seems to be extremely low risk, possibly even limited to the beta cluster only.

Change #1070978 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Add extra safe-guard to ve.ui.MWCitationDialogTool

https://gerrit.wikimedia.org/r/1070978

Locally, I see the issue that the reuse and extends tabs are still available. This was a mistake and is caused by the data source for those dialogs now coming from the full document and not only the caption fragment. (When no citations can be reused, the tabs are disabled.) Unfortunately, the reuse would be desirable but is not fully supported, see T336417: Reusing references inside and from a VE image/gallery dialog.

I don't see the console error, with or without the patch attached to this ticket.

We should disable the tabs for now.

Change #1070978 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add extra safe-guard to ve.ui.MWCitationDialogTool

https://gerrit.wikimedia.org/r/1070978

Change #1071826 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Try to always limit our document references to the current fragment

https://gerrit.wikimedia.org/r/1071826

Technical breadcrumb: MWDocumentReferences was accessing refs from the full document, so I've uploaded a patch limiting it to only see fragment refs for now.

Patch improves the situation but there are still problems. First of all, the image caption can be edited two different ways (directly clicking in the caption region, vs. opening the image dialog) and these already have divergent ref reuse behaviors. Second of all, these steps will lead to an "undefined" ref:

• add an image
• edit the caption and add a ref to it
• re-use the ref in the caption
• apply changes
• Result is [undefined][1] in the VE preview and on save just two ref's with the same content are created.

Breadcrumb: the issue first appears with commit 5b2cbc48bdf343991fbaf2621dc5fcd97bbe93c8 .

In T374068#10148680, @awight wrote:

on save just two ref's with the same content are created.

This seems to be the case since some time ( e.g. could reproduce that on v1.39.8 )

Change #1071826 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Try to always limit our document references to the current fragment

https://gerrit.wikimedia.org/r/1071826

In T374068#10149338, @awight wrote:

Since what remains after the patch is a "known bug" that has existed for years, I don't plan to work further on the issue until we can do another round of prioritization.

The bug is tracked under T374866: VE does not link ad-hoc re-uses of refs in an image caption now.