The Stats library (added in MW 1.41) attempts to better define the interface for generating metrics in MediaWiki. See Manual
As part of ensuring the whole of GrowthExperiments is using the Stats Library(Statslib) we should migrate the highlighted areas in GrowthExperiments.UserImpactHandler
Please follow the guidelines and standards outlined in the provided documentation:
- https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
- https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
- https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.
Acceptance Criteria
- MediaWiki.GrowthExperiments.UserImpactHandler.Cache.*
- MediaWiki.GrowthExperiments.UserImpactHandler.Cache.$UserImpactHandlerCache.sum
- MediaWiki.GrowthExperiments.UserImpactHandler.PingLimiterTripped.*
- MediaWiki.GrowthExperiments.UserImpactHandler.PingLimiterTripped.$UserImpactHandlerPingLimiter.rate
- MediaWiki.timing.growthExperiments.ComputedUserImpactLookup.getExpensiveUserImpact.p99
- MediaWiki.timing.growthExperiments.ComputedUserImpactLookup.getExpensiveUserImpact.sample_rate
Deploy and Verify changes
- Deploy the changes to production.
- Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
- Verify that the changes have been successfully implemented(This is nothing complex besides normal functionality and metrics captured are sent to Prometheus are queried from in-use dashboards.)