[M] Navigate away from new profile view
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	HNordeenWMF
	Sep 5 2024, 9:54 PM

Description

Background

As part of the Navigation refresh, T373712, we are creating a profile view that will be accessible from both article view and the main view for quick access to notifications, watchlist, and other items throughout the entire app.

Requirements

When tapping an item in profile view, dismiss, then push on or present destination view controller.
Clicking on notifications, user page (web view), talk page, watchlist, logout, settings, and donate for logged-in users takes you to those locations (not nested within the profile view)
If a user chooses to login or logout, they are returned to the page they were on before (profile view does not need to be open)
Functions for landscape and iPad

Designs

n/a

Related Objects
Search...

Status	Assigned	Task
Open	None	T373712 [Epic] iOS Navigation Refresh
Resolved	None	T373714 [Sub-Epic] Navigation Refresh Part 1 - Sept 2024
Resolved	None	T374166 [M] Navigate away from new profile view

Event Timeline

HNordeenWMF created this task.Sep 5 2024, 9:54 PM

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF mentioned this in T373714: [Sub-Epic] Navigation Refresh Part 1 - Sept 2024.Sep 5 2024, 10:33 PM

HNordeenWMF updated the task description. (Show Details)Sep 5 2024, 10:44 PM

HNordeenWMF triaged this task as Medium priority.Sep 5 2024, 11:25 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 5 2024, 11:27 PM

Seddon renamed this task from Navigate away from profile view to [M] Navigate away from new profile view.Sep 6 2024, 12:58 PM

Seddon set the point value for this task to 3.

Seddon moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener assigned this task to Mazevedo.Sep 6 2024, 1:52 PM

Tsevener updated the task description. (Show Details)Sep 9 2024, 2:39 PM

Tsevener mentioned this in T374160: [L] Create WMFComponent for new app wide profile view.

Mazevedo moved this task from Ready for future sprints to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 13 2024, 7:21 PM

HNordeenWMF updated the task description. (Show Details)Sep 17 2024, 2:42 PM

Tsevener mentioned this in T374879: [S] Show profile icon instead of notifications bell in for Settings view for explore feed opt-outs.Sep 19 2024, 2:25 PM

Mazevedo moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 20 2024, 5:59 PM

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/4982

Tsevener moved this task from Needs Code Review to Design signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 20 2024, 9:42 PM

@Tsevener

Great work and no surprises here; it is implemented as discussed regarding back behavior and labeling. We can think/talk about removing the "Back" label app-wide in the future.

• scblr moved this task from Design signoff to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Sep 26 2024, 5:24 PM

Tsevener removed Mazevedo as the assignee of this task.Sep 26 2024, 9:47 PM

Tsevener moved this task from Needs Code Review to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener added a subscriber: Mazevedo.

GOlson-WMF mentioned this in T375921: Release 7.6.0.Sep 27 2024, 7:00 PM

Looks good to mo on 7.6.0 (4147)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 4 2024, 3:58 PM

@Mazevedo I am running seeing 2 issues while clicking around

Issue 1
Steps to recreate:

Open article
Open profile and navigate to watchlist
Navigate back to article
Click search (from top right corner), then "cancel"

What happens

Profile & Search disappear from top

Issue 2
Steps to recreate:

Open Explore
Open profile and navigate to watchlist
Navigate back to Explore
Open article from explore
Navigate back to Explore

What happens

"Wikipedia" disappears from top

Edit: iOS 18.1 Beta, iPhone, 7.6.0 (4183)

HNordeenWMF mentioned this in T375445: [M] [BUG] Navigation bar layout on iPadOS 18 for watchlist and suggested edits.Oct 4 2024, 4:20 PM

Video: https://drive.google.com/file/d/1AmTrO5rn6UJXzvN7HgcRNklPJ9yrJgn8/view?usp=sharing

Tsevener claimed this task.Oct 4 2024, 8:24 PM

Tsevener moved this task from Did not pass QA to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

https://github.com/wikimedia/wikipedia-ios/pull/5005

I'm kicking off an Experimental build @HNordeenWMF. I don't think I fixed it entirely, but maybe it will be at least improved. I'm sorry that I'm such a broken record here, but this is our custom navigation bar acting up again. We need to prioritize T363606 as soon as we get a moment, or else these bugs will continue to chew up time as we work on features.

Experimental build will be 7.6.0 (171).

@Tsevener this looks good to me, the Profile/Search disappearing is fixed. The Logo disappearing is still happening but that is less concerning as it's not a button.