Page MenuHomePhabricator

Codex icons not loading on Vector 2022 via older versions of Chrome on Windows 7
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Main menu icon doesn't show.

What should have happened instead?:
Icon should show

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Per T373936#10124604, the icons also don't appear properly on Chrome for Windows 10, meaning possibly Chrome 128 or Chrome 129. It occurs more likely when using Windows 10's "Auto Dark Mode for Web Contents" option, but it might occur otherwise.

Derived Requirement

Ensure that the main menu icon on the Tech page of Meta-Wiki is displayed correctly in Chrome on Windows 7, Windows 10, and with "Auto Dark Mode for Web Contents" enabled.

BDD

Feature: Display of Main Menu Icon on Meta-Wiki

Scenario: Ensure main menu icon is displayed correctly on Windows 7 in Chrome

Given the user is viewing the Tech page on Meta-Wiki using Chrome on Windows 7
When the page loads
Then the main menu icon should be visible

Scenario: Ensure main menu icon is displayed correctly on Windows 10 with "Auto Dark Mode for Web Contents" enabled

Given the user is viewing the Tech page on Meta-Wiki using Chrome on Windows 10 with "Auto Dark Mode for Web Contents" enabled
When the page loads
Then the main menu icon should be visible
Test Steps

Test Case 1: Ensure Main Menu Icon Is Displayed on Windows 7 (Chrome 109)

On Windows 7, open Chrome version 109.
Navigate to this Meta-Wiki page.
✅❓❌⬜ AC1: Confirm that the main menu icon is visible.
Test Case 2: Ensure Main Menu Icon Is Displayed on Windows 10 (Chrome 128/129) with Auto Dark Mode

On Windows 10, enable "Auto Dark Mode for Web Contents" in Chrome (versions 128 or 129).
Navigate to this Meta-Wiki page.
✅❓❌⬜ AC1: Confirm that the main menu icon is visible.

QA Results - Meta Wiki

ACStatusDetails
1T374180#10141006
2T374180#10141006

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1071054 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Fix typo in browser vendor prefix

https://gerrit.wikimedia.org/r/1071054

Just to clarify, the issue occurs in only Vector 2022 skin via older Google Chrome version (<128 or <127). I checked other browsers, like Safari and Firefox, and I saw no issues there... yet. I also checked other skins besides Vector 2022 and found no similar occurrences.

Change #1071202 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/core@wmf/1.43.0-wmf.21] Fix typo in browser vendor prefix

https://gerrit.wikimedia.org/r/1071202

I've applied a hotfix on plwiki, maybe others will find it useful given the backport happens in over two days: https://pl.wikipedia.org/wiki/MediaWiki:Vector-2022.js

gh87 renamed this task from Codex icons not loading in older browsers to Codex icons not loading on Vector 2022 via Chrome.Sep 7 2024, 8:45 AM
gh87 updated the task description. (Show Details)

The icons are loaded, but they are not inverted by Chrome. Black drawing with black transparent background. Until Sep 6 they were inverted. Chrome 128, Windows 10 22H2, desktop, Auto dark mode setting of Chrome

Jdlrobson set the point value for this task to 1.Sep 9 2024, 5:22 PM

Change #1071202 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.21] Fix typo in browser vendor prefix

https://gerrit.wikimedia.org/r/1071202

Mentioned in SAL (#wikimedia-operations) [2024-09-09T20:49:10Z] <kindrobot@deploy1003> Started scap sync-world: Backport for [[gerrit:1071281|Release donate link to pilot wikis (French Wikipedia and Wikifunctions) (T373585)]], [[gerrit:1071202|Fix typo in browser vendor prefix (T374180)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-09T20:51:06Z] <kindrobot@deploy1003> jforrester, toyofuku, kindrobot: Backport for [[gerrit:1071281|Release donate link to pilot wikis (French Wikipedia and Wikifunctions) (T373585)]], [[gerrit:1071202|Fix typo in browser vendor prefix (T374180)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-09T21:01:49Z] <kindrobot@deploy1003> Finished scap sync-world: Backport for [[gerrit:1071281|Release donate link to pilot wikis (French Wikipedia and Wikifunctions) (T373585)]], [[gerrit:1071202|Fix typo in browser vendor prefix (T374180)]] (duration: 12m 39s)

Jdlrobson renamed this task from Codex icons not loading on Vector 2022 via Chrome to Codex icons not loading on Vector 2022 via older versions of Chrome on Windows 7.Sep 9 2024, 9:03 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.
Jdlrobson lowered the priority of this task from High to Medium.Sep 9 2024, 9:10 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, added: Edtadros.
GMikesell-WMF added a subscriber: Edtadros.

Test Result - Meta Wiki

Status: ✅ PASS
Environment: Meta Wiki
OS: macOS Sonoma 14.6.1
Browser: Chrome 128
Device: MBA
Emulated Device: NA

Test Artifact(s):
https://meta.wikimedia.org/wiki/Tech#OOUI_icons_currently_not_loading_or_appearing_in_projects

Test Steps

Test Case 1: Ensure Main Menu Icon Is Displayed on Windows 7 (Chrome 109)

On Windows 7, open Chrome version 109.
Navigate to this Meta-Wiki page.
✅ AC1: Confirm that the main menu icon is visible.
Test Case 2: Ensure Main Menu Icon Is Displayed on Windows 10 (Chrome 128/129) with Auto Dark Mode

2024-09-12_07-21-59.mp4.gif (650×1 px, 1 MB)

On Windows 10, enable "Auto Dark Mode for Web Contents" in Chrome (versions 128 or 129).
Navigate to this Meta-Wiki page.
✅ AC1: Confirm that the main menu icon is visible.

2024-09-12_07-23-46.mp4.gif (648×1 px, 1 MB)

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, removed: Edtadros.
GMikesell-WMF subscribed.
Jdlrobson claimed this task.