Page MenuHomePhabricator
Create Task
Maniphest T374191

upgrade clone cookbook
Closed, ResolvedPublic
Actions

Description

This task is to track what needs to be done before T368881
The initial PS is old and would be best kept as an artefact of T343674

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mariadb: clone cookbook maintenanceoperations/cookbooksmaster+184 -155
mysql_legacy: fix list_host_instancesoperations/software/spicerackmaster+39 -36
mysql_legacy: reuse old code pattern to avoid potential issueoperations/software/spicerackmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ABran-WMF created this task.Sep 6 2024, 6:58 AM
ABran-WMF changed the task status from Open to In Progress.
ABran-WMF triaged this task as Medium priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2024, 6:58 AM
ABran-WMF moved this task from Triage to In progress on the DBA board.Sep 6 2024, 6:58 AM
ABran-WMF moved this task from Todo to Doing on the Data-Persistence-Automations board.Sep 6 2024, 7:05 AM
gerritbot added a comment.Sep 6 2024, 9:45 AM

Change #1071155 had a related patch set uploaded (by Arnaudb; author: Arnaudb):

[operations/cookbooks@master] mariadb: clone cookbook maintenance

https://gerrit.wikimedia.org/r/1071155

gerritbot added a project: Patch-For-Review.Sep 6 2024, 9:45 AM
ABran-WMF moved this task from Doing to External dep/In review on the Data-Persistence-Automations board.Sep 6 2024, 11:54 AM
ABran-WMF changed the task status from In Progress to Stalled.Sep 19 2024, 7:05 AM
ABran-WMF moved this task from In progress to Blocked on the DBA board.
ABran-WMF changed the task status from Stalled to In Progress.Oct 8 2024, 9:13 AM
ABran-WMF moved this task from External dep/In review to Doing on the Data-Persistence-Automations board.
ABran-WMF added a subtask: T376712: mysql_legacy: SQL query quote escape.Oct 8 2024, 1:34 PM
ABran-WMF added a subtask: T376701: mysql_legacy data_directory getter.
ABran-WMF added a parent task: T368881: Make sre.mysql.clone handling pooling/depooling.
ABran-WMF added a parent task: T343674: Productionize db21[88-95].Oct 8 2024, 1:36 PM
ABran-WMF moved this task from Doing to External dep/In review on the Data-Persistence-Automations board.Oct 11 2024, 1:54 PM
ABran-WMF mentioned this in T377129: mariadb: systemctl status accessor in mysql_legacy.Oct 14 2024, 12:47 PM
ABran-WMF added a subtask: T377129: mariadb: systemctl status accessor in mysql_legacy.
ABran-WMF closed subtask T376701: mysql_legacy data_directory getter as Resolved.Oct 14 2024, 1:35 PM
ABran-WMF changed the task status from In Progress to Open.Oct 15 2024, 9:27 AM
ABran-WMF added a parent task: T239814: Automate DB upgrades.Oct 17 2024, 9:33 AM

as for T239814 → this will be covered by https://gerrit.wikimedia.org/r/c/1080718 in T368881

gerritbot added a comment.Oct 23 2024, 1:06 PM

Change #1082469 had a related patch set uploaded (by Arnaudb; author: Arnaudb):

[operations/software/spicerack@master] mysql_legacy: reuse old code pattern to avoid potential issue

https://gerrit.wikimedia.org/r/1082469

gerritbot added a comment.Oct 23 2024, 1:26 PM

Change #1082469 abandoned by Arnaudb:

[operations/software/spicerack@master] mysql_legacy: reuse old code pattern to avoid potential issue

Reason:

as discussed, this will be replaced by a comment on the cookbook where it was found, so if it fails it is identifiable.

https://gerrit.wikimedia.org/r/1082469

ABran-WMF mentioned this in T368881: Make sre.mysql.clone handling pooling/depooling.Oct 23 2024, 1:42 PM
ABran-WMF closed subtask T376712: mysql_legacy: SQL query quote escape as Declined.
ABran-WMF closed subtask T377129: mariadb: systemctl status accessor in mysql_legacy as Resolved.Oct 23 2024, 1:47 PM
gerritbot added a comment.Oct 29 2024, 3:05 PM

Change #1084132 had a related patch set uploaded (by Arnaudb; author: Arnaudb):

[operations/software/spicerack@master] mysql_legacy: fix _list_host_instances

https://gerrit.wikimedia.org/r/1084132

gerritbot added a comment.Oct 31 2024, 3:16 PM

Change #1084132 merged by jenkins-bot:

[operations/software/spicerack@master] mysql_legacy: fix list_host_instances

https://gerrit.wikimedia.org/r/1084132

ABran-WMF removed ABran-WMF as the assignee of this task.Jan 13 2025, 3:39 PM
Marostegui closed this task as Resolved.Jan 16 2025, 11:24 AM
Marostegui subscribed.

I am going to close this task and open some more detailed ones with what could be next steps for the upgrade cookbook. As both items listed on this task are closed as resolved but there are no more items to do.

gerritbot added a comment.Jul 28 2025, 1:46 PM

Change #1071155 abandoned by Arnaudb:

[operations/cookbooks@master] mariadb: clone cookbook maintenance

https://gerrit.wikimedia.org/r/1071155

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2025, 2:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits