Page MenuHomePhabricator

Use a speech bubble icon for HTML comments
Open, Needs TriagePublic

Assigned To
None
Authored By
Esanders
Sep 6 2024, 9:01 AM
Referenced Files
F57467584: image.png
Sep 6 2024, 9:01 AM
F57467578: image.png
Sep 6 2024, 9:01 AM
Subscribers

Description

HTML comments are shown with a generic "notice" icon, however as such comments are part of the user generated content and (usually) actual human generated "comments" it would make more sense to use the speech bubble icon used elsewhere. A speech bubble icon with a ! also exists in Echo and so this can just be copied over to VE.

A speech bubble better highlights this as a message from other editors, rather than a system-generated error/notice that needs to be "fixed" or otherwise addressed.

BeforeAfter
image.png (740×339 px, 98 KB)
image.png (740×339 px, 104 KB)

Event Timeline

Change #1071584 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Use speechBubbleNotice icon for CommentNode

https://gerrit.wikimedia.org/r/1071584

Change #1071584 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Use speechBubbleNotice icon for CommentNode

https://gerrit.wikimedia.org/r/1071584

Change #1071894 had a related patch set uploaded (by Jforrester; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I4e7b8593: Use new icon for "Comment" toolbar tool, and add variants

https://gerrit.wikimedia.org/r/1071894

Change #1071894 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I4e7b8593: Use new icon for "Comment" toolbar tool, and add variants

https://gerrit.wikimedia.org/r/1071894

Change #1071912 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ed9e2d8c1)

https://gerrit.wikimedia.org/r/1071912

Change #1071912 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5a0396522)

https://gerrit.wikimedia.org/r/1071912