Page MenuHomePhabricator

Make use of newInstrument to reduce boilerplating
Closed, ResolvedPublic

Description

In metrics-platform/-/merge_requests/39 a new convenience method is introduced MetricsClient#newInstrument( streamName, schemaID ) to facilitate the creation of configured loggers.

This is blocked for now on T366827: Update the Metrics Platform JS Client Library API to talk about Instrument Name, but once that is resolved it would be nice to adopt the API.

Event Timeline

Sgs renamed this task from Make use of createMetricsClient and newInstrument to reduce boilerplating to Make use of newInstrument to reduce boilerplating.Sep 9 2024, 11:31 AM

Change #1071587 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Community updates: use MetricsPlatform.newInstrument

https://gerrit.wikimedia.org/r/1071587

Sgs changed the task status from Open to Stalled.Sep 17 2024, 9:20 AM
Sgs triaged this task as Low priority.
Sgs removed Sgs as the assignee of this task.Sep 17 2024, 3:32 PM

Unassigned since I'm not actively working on this.

Sgs changed the task status from Stalled to Open.Oct 9 2024, 9:43 AM
Sgs claimed this task.
Sgs edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team.
Sgs moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change #1071587 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Community updates: use MetricsPlatform.newInstrument

https://gerrit.wikimedia.org/r/1071587

Etonkovidova subscribed.

Checked on beta for mediawiki.product_metrics.homepage_module_interaction stream - works as expected.