Page MenuHomePhabricator
Create Task
Maniphest T374248

ZObjectSelector: Adapt to new CdxLookup behavior after release v1.12.0
Closed, ResolvedPublic
Actions

Description

Description

We need to:

  • remove initialInputValue and lookupKey counter
  • use inputValue prop instead
  • [BUG] T374246 remove clear field strategy when update:selected is triggered with null value

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix LanguageSelector use of CdxLookup v1.12.0mediawiki/extensions/WikiLambdamaster+20 -12
Fix ZObjectSelector use of CdxLookup v1.12.0mediawiki/extensions/WikiLambdamaster+91 -62
Fix CdxLookup after Codex release v1.12.0mediawiki/extensions/WikiLambdamaster+10 -13
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Sep 6 2024, 2:52 PM
gerritbot added a comment.Sep 6 2024, 2:57 PM

Change #1071226 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix CdxLookup after Codex release v1.12.0

https://gerrit.wikimedia.org/r/1071226

gerritbot added a project: Patch-For-Review.Sep 6 2024, 2:57 PM
gerritbot added a comment.Sep 6 2024, 6:36 PM

Change #1071226 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix CdxLookup after Codex release v1.12.0

https://gerrit.wikimedia.org/r/1071226

Jdforrester-WMF triaged this task as Unbreak Now! priority.Sep 6 2024, 6:46 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 6 2024, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 6 2024, 7:30 PM
Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Sep 9 2024, 2:50 PM
Jdforrester-WMF lowered the priority of this task from Unbreak Now! to Needs Triage.Sep 10 2024, 1:01 PM
Jdforrester-WMF triaged this task as High priority.
gerritbot added a comment.Sep 13 2024, 4:20 PM

Change #1072778 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix ZObjectSelector use of CdxLookup v1.12.0

https://gerrit.wikimedia.org/r/1072778

gerritbot added a project: Patch-For-Review.Sep 13 2024, 4:20 PM
gerritbot added a comment.Sep 17 2024, 2:20 PM

Change #1072778 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix ZObjectSelector use of CdxLookup v1.12.0

https://gerrit.wikimedia.org/r/1072778

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2024, 2:31 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.24; 2024-09-24); removed MW-1.43-notes (1.43.0-wmf.22; 2024-09-10).Sep 17 2024, 3:00 PM
gerritbot added a comment.Sep 21 2024, 6:42 PM

Change #1074580 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix LanguageSelector use of CdxLookup v1.12.0

https://gerrit.wikimedia.org/r/1074580

gerritbot added a project: Patch-For-Review.Sep 21 2024, 6:42 PM
Jdforrester-WMF moved this task from In Progress to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Sep 23 2024, 11:38 AM
gerritbot added a comment.Sep 23 2024, 12:31 PM

Change #1074580 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix LanguageSelector use of CdxLookup v1.12.0

https://gerrit.wikimedia.org/r/1074580

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2024, 1:30 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Sep 25 2024, 7:14 PM
Jdforrester-WMF closed this task as Resolved.Oct 8 2024, 1:48 PM
Jdforrester-WMF assigned this task to gengh.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits