Page MenuHomePhabricator
Create Task
Maniphest T374277

View full log does not work on wikis with language other than English
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
Dreamy_Jazz
Authored By
Urbanecm
Sep 6 2024, 7:57 PM
Tags
Referenced Files
F57507267: image.png
Sep 14 2024, 5:08 AM
F57507256: image.png
Sep 14 2024, 5:08 AM
F57507295: image.png
Sep 14 2024, 5:08 AM
F57507289: image.png
Sep 14 2024, 5:08 AM
Subscribers
Aklapper
Djackson-ctr
Dreamy_Jazz
JJMC89
Johannnes89
kostajh
Urbanecm

Description

Steps to replicate the issue (include links if applicable):

What happens?:

You're sent to https://meta.wikimedia.org/wiki/Speci%C3%A1ln%C3%AD:Protokolovac%C3%AD_z%C3%A1znamy?type=gblblock&page=126.110.226.230, which is a 404, because Meta's language is English

What should have happened instead?:

The link should've been https://meta.wikimedia.org/wiki/Special:Log?type=gblblock&page=126.110.226.230

Other information (browser name/version, screenshots, etc.):

The link generated depends on wgLanguage, not on user language.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Generate special page name in English for central URLsmediawiki/extensions/GlobalBlockingwmf/1.43.0-wmf.22+19 -5
Generate special page name in English for central URLsmediawiki/extensions/GlobalBlockingmaster+19 -5
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Sep 6 2024, 7:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2024, 7:57 PM
JJMC89 added subscribers: Dreamy_Jazz, JJMC89.Sep 6 2024, 8:26 PM

The same applies to the global block log link in the subtitle.

Johannnes89 subscribed.Sep 8 2024, 8:56 AM
Dreamy_Jazz claimed this task.Sep 9 2024, 3:20 PM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz added projects: Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).

Adding to our sprint board as a bug caused by some of our recent patches.

Dreamy_Jazz changed the point value for this task from 2 to 1.Sep 9 2024, 3:30 PM

The way that MediaWiki-extensions-CentralAuth does this is by using the English language name for the special page. This should work even if the central wiki does not use English, as it should redirect to the localised version.

gerritbot added a comment.Sep 9 2024, 3:45 PM

Change #1071641 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Generate special page name in English for central URLs

https://gerrit.wikimedia.org/r/1071641

gerritbot added a project: Patch-For-Review.Sep 9 2024, 3:45 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 9 2024, 4:06 PM
kostajh moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 11 2024, 7:28 AM
kostajh subscribed.

@Dreamy_Jazz should we backport this to wmf.22?

gerritbot added a comment.Sep 11 2024, 7:38 AM

Change #1071641 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Generate special page name in English for central URLs

https://gerrit.wikimedia.org/r/1071641

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Sep 11 2024, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2024, 8:30 AM
gerritbot added a comment.Sep 11 2024, 10:05 AM

Change #1072159 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@wmf/1.43.0-wmf.22] Generate special page name in English for central URLs

https://gerrit.wikimedia.org/r/1072159

gerritbot added a project: Patch-For-Review.Sep 11 2024, 10:05 AM
Dreamy_Jazz added a comment.Sep 11 2024, 10:06 AM
In T374277#10136472, @kostajh wrote:

@Dreamy_Jazz should we backport this to wmf.22?

I'm fine either way, so will defer to backporting.

gerritbot added a comment.Sep 11 2024, 1:10 PM

Change #1072159 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.43.0-wmf.22] Generate special page name in English for central URLs

https://gerrit.wikimedia.org/r/1072159

Stashbot mentioned this in T374455: Create the "arbcom" user group on zhwiki.Sep 11 2024, 1:27 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-11T13:27:41Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1071838|Remove ResourceLoaderUseObjectCacheForDeps (T343492)]], [[gerrit:1072159|Generate special page name in English for central URLs (T374277)]], [[gerrit:1072176|IPInfoLogFormatter: Avoid unnecessary User object creation (T374526)]], [[gerrit:1071902|Add arbcom group to zhwiki (T374455)]], [[gerrit:1072177|Remove redundant oathauth-enable flag (

Stashbot mentioned this in T374526: InvalidArgumentException: Invalid IP address error when loading IPInfo logs.Sep 11 2024, 1:27 PM
Stashbot mentioned this in T343492: Phase out SqlModuleDependencyStore.
Stashbot added a comment.Sep 11 2024, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-11T13:29:49Z] <dreamyjazz@deploy1003> jdrewniak, hokwelum, dreamyjazz, hamishz: Backport for [[gerrit:1071838|Remove ResourceLoaderUseObjectCacheForDeps (T343492)]], [[gerrit:1072159|Generate special page name in English for central URLs (T374277)]], [[gerrit:1072176|IPInfoLogFormatter: Avoid unnecessary User object creation (T374526)]], [[gerrit:1071902|Add arbcom group to zhwiki (T374455)]], [[gerrit:1072177|Remove redundant oatha

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2024, 1:31 PM
Stashbot added a comment.Sep 11 2024, 1:40 PM

Mentioned in SAL (#wikimedia-operations) [2024-09-11T13:40:51Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1071838|Remove ResourceLoaderUseObjectCacheForDeps (T343492)]], [[gerrit:1072159|Generate special page name in English for central URLs (T374277)]], [[gerrit:1072176|IPInfoLogFormatter: Avoid unnecessary User object creation (T374526)]], [[gerrit:1071902|Add arbcom group to zhwiki (T374455)]], [[gerrit:1072177|Remove redundant oathauth-enable flag

Dreamy_Jazz closed this task as Resolved.Sep 11 2024, 1:50 PM

Will be fixed within a few days on all wikis as the change is now in wmf.22.

Dreamy_Jazz reopened this task as Open.Sep 11 2024, 1:53 PM

Forgot about QA :D.

For QA you should be able to follow the testing steps but replace the URL in step 1 with https://se.wikibooks.org/wiki/Erenoam%C3%A1%C5%A1:Rievdadusat/126.110.226.230

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Sep 11 2024, 2:00 PM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 14 2024, 5:08 AM
Djackson-ctr subscribed.

QA has been completed and the new code changes have been implemented (When the user clicks View Full Log, that user will be redirected to the url https://meta.wikimedia.org/wiki/Special:Log?type=gblblock in the corresponding language of the user's wiki).

image.png (994×1 px, 177 KB)

image.png (962×1 px, 143 KB)

image.png (972×1 px, 115 KB)

image.png (953×1 px, 142 KB)

kostajh closed this task as Resolved.Sep 14 2024, 8:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits