Page MenuHomePhabricator

Automoderator should respect account blocks
Closed, ResolvedPublic3 Estimated Story Points

Description

If Automoderator's account is blocked, it should no longer attempt to edit on a wiki.

Because Automoderator is a system account it may continue making edits despite being blocked. If an administrator blocks the account because they're not aware that the Community Configuration form exists, but they want to stop Automoderator taking actions, then the software should respect that block.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jsn.sherman set the point value for this task to 3.Sep 17 2024, 3:15 PM
jsn.sherman moved this task from To be estimated to Up next on the Moderator-Tools-Team board.

Change #1075061 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] Automoderator should respect account blocks

https://gerrit.wikimedia.org/r/1075061

Change #1075061 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Automoderator should respect account blocks

https://gerrit.wikimedia.org/r/1075061

Tested this on test wiki by fully blocking Automoderator and making some edits which were previously being reverted. Automoderator did not revert the edits, as expected. After unblocking it began reverting again.

I also tested with a partial block which did not apply to the edit I was making (I blocked it from the File namespace), but Automoderator still did not make a revert. That's not what users would expect to happen, but I think there's very little chance an administrator partially blocks Automoderator so I think we can handle that case if it ever comes up.

Change #1077982 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/AutoModerator@master] Automoderator should respect account blocks and partial blocks

https://gerrit.wikimedia.org/r/1077982

Change #1077982 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Automoderator should respect account blocks and partial blocks

https://gerrit.wikimedia.org/r/1077982

I have blocked AutoModeratorTest for 1 day to ensure no reverts go through during this time period.
I have also tested by making "fake" bad reverts on test wiki and have not seen any reverts come through since blocking AutoModeratorTest.

No reverts went through during the time that AM was blocked. I'm now setting it to be a partial block on talk pages and letting it sit for awhile to make sure a revert still kicks off on non talk pages.

The partial block functionality worked as expected. See https://test.wikipedia.org/w/index.php?title=Kangaru,_Iran&action=history

Will remove partial block from AutoModeratorTest and resolve this ticket.