Page MenuHomePhabricator

Radio: create new border token
Closed, ResolvedPublic1 Estimated Story Points

Description

Overview

After implementing Radio error states (T363515), there's a need to create a new border color token: @border-color-error-active and a component-level 4px border width token.

We currently use @border-color-destructive-active (Red800) because @border-color-error-active doesn't exist in our design system. When this token becomes available, we can replace references to @border-color-destructive-active token with @border-color-error-active in Radio and Checkbox.

We need to create the @border-color-error-active in both Light and Dark modes, using the following tokens:

  • Light mode: Red700
  • Dark mode: Red700
NOTE: there is no need to create a different width for the focus state since the error focus uses the blue color.

Acceptance Criteria

Design:

  • Decide on the need for this new token
  • Include the token as Figma variable and update it in the Radio and Checkbox in Figma

Code:

  • Create the new @border-color-error-active token in code using
    • Light mode: Red700
    • Dark mode: Red700
  • Replace @border-color-destructive-active with @border-color-error-active in Radio.

Details

Event Timeline

lwatson renamed this task from Radio, Checkbox: create new error color tokens to Radio, Checkbox: create new border color token.Sep 10 2024, 3:24 PM
lwatson updated the task description. (Show Details)
lwatson renamed this task from Radio, Checkbox: create new border color token to Radio, Checkbox: create new tokens.Sep 12 2024, 2:39 PM
lwatson updated the task description. (Show Details)
CCiufo-WMF triaged this task as Medium priority.Sep 13 2024, 8:06 PM
CCiufo-WMF set the point value for this task to 1.Oct 7 2024, 5:19 PM
CCiufo-WMF added a project: Design.
CCiufo-WMF added a subscriber: bmartinezcalvo.

@bmartinezcalvo if the colors for the new tokens have already been decided, can you add them to the task description?

CCiufo-WMF lowered the priority of this task from Medium to Low.Oct 7 2024, 5:21 PM
CCiufo-WMF moved this task from Needs Refinement to Up Next on the Design-System-Team board.

Change #1079582 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] codex: create border-color-error--active token

https://gerrit.wikimedia.org/r/1079582

lwatson renamed this task from Radio, Checkbox: create new tokens to Radio: create new tokens.Oct 17 2024, 3:18 PM
lwatson updated the task description. (Show Details)
lwatson renamed this task from Radio: create new tokens to Radio: create new border token.Oct 17 2024, 3:30 PM

Change #1079582 merged by jenkins-bot:

[design/codex@main] tokens: create border-color-error--active token

https://gerrit.wikimedia.org/r/1079582

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/a5d0a31f72/w/

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/a5d0a31f72/w/