Page MenuHomePhabricator

Clicking "External maps" is not working in Kartographer
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Nothing happens

What should have happened instead?:
List of external maps should show up

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Firefox 130.0

Event Timeline

Change #1072165 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix Kartographer sidebar failing to load

https://gerrit.wikimedia.org/r/1072165

thiemowmde added subscribers: Krinkle, • matmarex.

I was able to identify https://gerrit.wikimedia.org/r/1068064 as the root cause for this, tracked via T373065: require('../bar/baz.js') fails from top of module directory.

There is a require( '../../externalLinks.json' ) in the Maps (Kartographer) code. That relative path is correct. The file is indeed two levels up from the perspective of the script where the require() call is.

Unfortunately this relative path is not resolved any more after https://gerrit.wikimedia.org/r/1068064. The require() call fails and the code just stops. There is no error message printed anywhere for some reason.

There is a require( '../../externalLinks.json' ) in the Maps (Kartographer) code. That relative path is correct. The file is indeed two levels up from the perspective of the script where the require() call is.

There is a file there, but that's not the file that it's actually shipping with the module. The file it's shipping is a virtual one, defined here: https://gerrit.wikimedia.org/g/mediawiki/extensions/Kartographer/+/898ef4fe5c93680190e0506bd6b58aea3801d787/extension.json#250 and the correct path to that file would be just require( './externalLinks.json' ).

Change #1072165 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix Kartographer sidebar failing to load

https://gerrit.wikimedia.org/r/1072165

Change #1087431 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Different file name for virtual vs. physical externalLinks.json

https://gerrit.wikimedia.org/r/1087431

Change #1087431 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Different file name for virtual vs. physical externalLinks.json

https://gerrit.wikimedia.org/r/1087431