Page MenuHomePhabricator
Create Task
Maniphest T374533

Add Wikidata reference types & add/update retrieval functions to use them
Closed, ResolvedPublic
Actions

Description

Description

Rather than using Z9/Reference to refer to instances of Wikidata-based types, we will create a new reference type corresponding to each of the Wikidata-based types Z6001, Z6002, Z6004, Z6005, & Z6006. For each of these, there will be a built-in retrieval function, which will take the reference type as input and return an instance of the corresponding Wikidata-based type.

Retrieval functions and implementations already exist for Z6004 & Z6005. To have a complete set, we add new functions and implementations for Z6001, Z6002 & Z6006.

  • New reference types Z6691/2/4/5/6 (renamed to Z6091/2/4/5/6)
  • Updates to retrieval functions Z6824/5
  • New retrieval functions Z6821/2/6
  • New implementations Z6921/2/6

Completion checklist

Details

TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (c399cc8)repos/abstract-wiki/wikifunctions/function-evaluator!258jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (c399cc8)repos/abstract-wiki/wikifunctions/wikilambda-cli!51jforrestersync-function-schematamain
Update ZIDs of Wikidata reference types throughout orchestratorrepos/abstract-wiki/wikifunctions/function-orchestrator!230dmartinT374533main
Rename Wikidata reference types from Z669x to Z609xrepos/abstract-wiki/wikifunctions/function-schemata!163dmartinT374533-2main
Update function-schemata sub-module to HEAD (58d403a)repos/abstract-wiki/wikifunctions/function-orchestrator!228jforrestersync-function-schemata-onlymain
Update function-schemata sub-module to HEAD (58d403a)repos/abstract-wiki/wikifunctions/function-evaluator!257jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (58d403a)repos/abstract-wiki/wikifunctions/wikilambda-cli!50jforrestersync-function-schematamain
Draft: Update function-schemata sub-module to HEAD (58d403a)repos/abstract-wiki/wikifunctions/function-orchestrator!227dmartinsync-function-schematamain
definitions: Add Wikidata reference types Z6691–Z6696, add/update retrieval functions to use themrepos/abstract-wiki/wikifunctions/function-schemata!160dmartinT374533main
Customize query in GitLab

Related Objects
Search...

Event Timeline

DMartin-WMF created this task.Sep 11 2024, 12:47 PM
CodeReviewBot added a project: Patch-For-Review.Sep 11 2024, 1:00 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/160

Draft: Add Wikidata reference types, add/update retrieval functions to use them

CodeReviewBot added a comment.Sep 13 2024, 6:51 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/160

definitions: Add Wikidata reference types Z6691–Z6696, add/update retrieval functions to use them

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2024, 7:30 PM
DMartin-WMF claimed this task.Sep 14 2024, 3:41 PM
DMartin-WMF updated the task description. (Show Details)
DMartin-WMF changed the task status from Open to In Progress.Sep 15 2024, 8:15 PM
CodeReviewBot added a project: Patch-For-Review.Sep 16 2024, 10:54 AM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/227

Update function-schemata sub-module to HEAD (58d403a)

CodeReviewBot added a comment.Sep 16 2024, 11:37 AM

dmartin closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/227

Draft: Update function-schemata sub-module to HEAD (58d403a)

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2024, 12:30 PM
DMartin-WMF closed this task as Resolved.Sep 16 2024, 12:38 PM
DMartin-WMF added a parent task: T282926: [25Q1] Allow for users to specify Wikidata items in function evaluation requests.
CodeReviewBot added a project: Patch-For-Review.Sep 16 2024, 1:33 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/50

Update function-schemata sub-module to HEAD (58d403a)

gerritbot added a comment.Sep 16 2024, 1:33 PM

Change #1073217 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (58d403a)

https://gerrit.wikimedia.org/r/1073217

CodeReviewBot added a comment.Sep 16 2024, 1:33 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/257

Update function-schemata sub-module to HEAD (58d403a)

CodeReviewBot added a comment.Sep 16 2024, 1:34 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/228

Update function-schemata sub-module to HEAD (58d403a)

CodeReviewBot added a comment.Sep 16 2024, 3:20 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/50

Update function-schemata sub-module to HEAD (58d403a)

CodeReviewBot added a comment.Sep 16 2024, 3:28 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/257

Update function-schemata sub-module to HEAD (58d403a)

gerritbot added a comment.Sep 17 2024, 1:54 PM

Change #1073458 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (58d403aa)

https://gerrit.wikimedia.org/r/1073458

gerritbot added a comment.Sep 17 2024, 5:17 PM

Change #1073491 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (58d403a)

https://gerrit.wikimedia.org/r/1073491

gerritbot added a comment.Sep 17 2024, 9:12 PM

Change #1073458 abandoned by Genoveva Galarza:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (58d403aa)

Reason:

Duplicates

https://gerrit.wikimedia.org/r/1073458

gerritbot added a comment.Sep 17 2024, 10:49 PM

Change #1073491 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (58d403a)

https://gerrit.wikimedia.org/r/1073491

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.24; 2024-09-24).Sep 17 2024, 11:00 PM
DMartin-WMF reopened this task as In Progress.Sep 19 2024, 8:27 PM

Reopening because we've decided to change the ZIDs of the 5 reference types, from Z669x to Z609x. That will be done in a single schemata patch, followed by a single orchestrator MR.

CodeReviewBot added a comment.Sep 19 2024, 8:48 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/163

Rename Wikidata reference types from Z669x to Z609x

CodeReviewBot added a comment.Sep 20 2024, 9:41 AM

gengh merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/163

Rename Wikidata reference types from Z669x to Z609x

CodeReviewBot added a comment.Sep 20 2024, 1:07 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/230

Update ZIDs of Wikidata reference types throughout orchestrator

CodeReviewBot added a comment.Sep 20 2024, 6:24 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/230

Update ZIDs of Wikidata reference types throughout orchestrator

CodeReviewBot added a comment.Sep 22 2024, 8:16 PM

dmartin opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/231

Draft: Update ZIDs of Wikidata reference types throughout orchestrator

DMartin-WMF updated the task description. (Show Details)Sep 23 2024, 6:51 AM
DMartin-WMF closed this task as Resolved.Sep 23 2024, 7:45 AM

Re-closing; the schemata and orchestrator patches for renaming the reference types have both merged.

gerritbot added a comment.Sep 23 2024, 11:50 AM

Change #1073217 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (58d403a)

Reason:

Done later in I83d8658aa05d6cce81fd9fb89244aa27f6079296 instead.

https://gerrit.wikimedia.org/r/1073217

CodeReviewBot added a comment.Sep 23 2024, 1:14 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/51

Update function-schemata sub-module to HEAD (c399cc8)

CodeReviewBot added a comment.Sep 23 2024, 1:17 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/258

Update function-schemata sub-module to HEAD (c399cc8)

CodeReviewBot added a comment.Sep 23 2024, 1:18 PM

jforrester closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/228

Update function-schemata sub-module to HEAD (58d403a)

gerritbot added a comment.Sep 23 2024, 1:20 PM

Change #1075008 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (c399cc8)

https://gerrit.wikimedia.org/r/1075008

CodeReviewBot added a comment.Sep 23 2024, 2:08 PM

dmartin merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/51

Update function-schemata sub-module to HEAD (c399cc8)

gerritbot added a comment.Sep 23 2024, 2:11 PM

Change #1075008 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (c399cc8)

https://gerrit.wikimedia.org/r/1075008

CodeReviewBot added a comment.Sep 23 2024, 5:31 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/258

Update function-schemata sub-module to HEAD (c399cc8)

gerritbot added a comment.Sep 25 2024, 12:52 PM

Change #1075554 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-08-13-135124 to 2024-09-24-145528

https://gerrit.wikimedia.org/r/1075554

gerritbot added a comment.Sep 25 2024, 12:52 PM

Change #1075555 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-08-20-132618 to 2024-09-24-221243

https://gerrit.wikimedia.org/r/1075555

gerritbot added a comment.Sep 25 2024, 9:06 PM

Change #1075554 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-08-13-135124 to 2024-09-24-145528

https://gerrit.wikimedia.org/r/1075554

gerritbot added a comment.Sep 25 2024, 9:15 PM

Change #1075555 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-08-20-132618 to 2024-09-24-221243

https://gerrit.wikimedia.org/r/1075555

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.Sep 25 2024, 9:38 PM
Jdforrester-WMF moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits