Page MenuHomePhabricator

Migrate to UnionQueryBuilder in Extensions
Open, In Progress, MediumPublic

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, the listed extensions below should migrate away from building and passing around raw unionQueries SQL to UnionQueryBuilder

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::unionQueries() indicate that raw SQL is being built and passed around.

  • CommentStreams
  • ContributionScores
  • SafeDelete
  • Sofa

Related CodeSearch

Event Timeline

Atieno changed the task status from Open to In Progress.Sep 18 2024, 3:25 PM

Change #1074201 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/CommentStreams@master] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1074201

Change #1074467 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/SafeDelete@master] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1074467

Change #1075586 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/Sofa@master] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1075586

Marked femiwiki/UnifiedExtensionForFemiwiki and hexmode/mediawiki-PeriodicRelatedChanges as private repos so beyond this work's scope

Change #1074467 merged by jenkins-bot:

[mediawiki/extensions/SafeDelete@master] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1074467

Change #1074201 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1074201

@Atieno -- is this still open? When you get a chance, please update the status and progress on the ticket.

Change #1112399 had a related patch set uploaded (by MarkAHershberger; author: Atieno):

[mediawiki/extensions/CommentStreams@REL1_43] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1112399

Change #1112399 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_43] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1112399

Change #1075586 merged by jenkins-bot:

[mediawiki/extensions/Sofa@master] Migrate to UnionQueryBuilder

https://gerrit.wikimedia.org/r/1075586