Page MenuHomePhabricator
Create Task
Maniphest T374702

Cleanup: Remove deprecated weighted tag methods
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

As part of T372904 some methods concerned with weighted tags have been deprecated. For the sake of cleaning up the code base, they shall be removed.

AC:

  • remove methods marked @deprecated as part of T372904, in particular from CirrusSearch, DataSender, and MultiListBuilder
  • adapt tests to use the replacement methods

Details

SubjectRepoBranchLines +/-
Drop legacy weighted_tags methodsmediawiki/extensions/CirrusSearchmaster+12 -214
Use WeightedTagsUpdater service in UpdateWeightedTagsmediawiki/extensions/CirrusSearchmaster+8 -5
cirrus: cleanup unused settingsoperations/mediawiki-configmaster+0 -2
Remove deprecated DataSender methods to send/reset weighted tagsmediawiki/extensions/CirrusSearchmaster+0 -57
Update DataSenderTest to use non-deprecated methodsmediawiki/extensions/CirrusSearchmaster+23 -368
Use WeightedTagsUpdatermediawiki/extensions/GrowthExperimentsmaster+9 -7
Use WeightedTagsUpdatermediawiki/extensions/GrowthExperimentsmaster+8 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

pfischer created this task.Sep 13 2024, 11:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2024, 11:28 AM
Aklapper added a project: Technical-Debt.Sep 13 2024, 12:15 PM
dr0ptp4kt moved this task from needs triage to Current work on the Discovery-Search board.Sep 16 2024, 3:28 PM
dr0ptp4kt edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dr0ptp4kt assigned this task to pfischer.Sep 16 2024, 3:31 PM
dr0ptp4kt triaged this task as Medium priority.
dr0ptp4kt moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
dr0ptp4kt set the point value for this task to 2.
pfischer moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.Oct 29 2024, 4:00 PM
gerritbot added a comment.Oct 30 2024, 11:11 AM

Change #1084737 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/GrowthExperiments@master] Use WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1084737

gerritbot added a project: Patch-For-Review.Oct 30 2024, 11:11 AM
gerritbot added a comment.Oct 30 2024, 11:17 AM

Change #1084738 had a related patch set uploaded (by Peter Fischer; author: Peter Fischer):

[mediawiki/extensions/GrowthExperiments@master] Use WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1084738

gerritbot added a comment.Oct 30 2024, 11:18 AM

Change #1084737 abandoned by Peter Fischer:

[mediawiki/extensions/GrowthExperiments@master] Use WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1084737

gerritbot added a comment.Nov 6 2024, 1:10 PM

Change #1084738 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use WeightedTagsUpdater

https://gerrit.wikimedia.org/r/1084738

Maintenance_bot removed a project: Patch-For-Review.Nov 6 2024, 1:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Nov 6 2024, 2:00 PM
Gehel reassigned this task from pfischer to dcausse.Jan 20 2025, 4:31 PM
gerritbot added a comment.Jan 20 2025, 6:49 PM

Change #1112829 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Update DataSenderTest to use non-deprecated methods

https://gerrit.wikimedia.org/r/1112829

gerritbot added a project: Patch-For-Review.Jan 20 2025, 6:49 PM

Change #1112830 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Remove deprecated DataSender methods to send/reset weighted tags

https://gerrit.wikimedia.org/r/1112830

dcausse moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Jan 20 2025, 6:51 PM
dcausse moved this task from Needs review to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.Jan 21 2025, 4:47 PM

Change #1112829 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Update DataSenderTest to use non-deprecated methods

https://gerrit.wikimedia.org/r/1112829

gerritbot added a comment.Jan 21 2025, 4:48 PM

Change #1112830 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Remove deprecated DataSender methods to send/reset weighted tags

https://gerrit.wikimedia.org/r/1112830

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.14; 2025-01-28); removed MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Jan 21 2025, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 21 2025, 5:31 PM
gerritbot added a comment.Jan 23 2025, 9:37 AM

Change #1113750 had a related patch set uploaded (by DCausse; author: DCausse):

[operations/mediawiki-config@master] cirrus: cleanup unused settings

https://gerrit.wikimedia.org/r/1113750

gerritbot added a project: Patch-For-Review.Jan 23 2025, 9:37 AM
gerritbot added a comment.Jan 23 2025, 2:08 PM

Change #1113750 merged by jenkins-bot:

[operations/mediawiki-config@master] cirrus: cleanup unused settings

https://gerrit.wikimedia.org/r/1113750

Stashbot added a comment.Jan 23 2025, 2:09 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-23T14:09:11Z] <samtar@deploy2002> Started scap sync-world: Backport for [[gerrit:1113463|cirrus: stop writing to wikitech index from the MW JobQueue]], [[gerrit:1113750|cirrus: cleanup unused settings (T374702)]]

Stashbot added a comment.Jan 23 2025, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-23T14:13:48Z] <samtar@deploy2002> dcausse, samtar: Backport for [[gerrit:1113463|cirrus: stop writing to wikitech index from the MW JobQueue]], [[gerrit:1113750|cirrus: cleanup unused settings (T374702)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 23 2025, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2025-01-23T14:21:11Z] <samtar@deploy2002> Finished scap sync-world: Backport for [[gerrit:1113463|cirrus: stop writing to wikitech index from the MW JobQueue]], [[gerrit:1113750|cirrus: cleanup unused settings (T374702)]] (duration: 12m 00s)

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2025, 2:30 PM
gerritbot added a comment.Jan 28 2025, 10:33 AM

Change #1114669 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Use WeightedTagsUpdater service in UpdateWeightedTags

https://gerrit.wikimedia.org/r/1114669

gerritbot added a project: Patch-For-Review.Jan 28 2025, 10:33 AM

Change #1114670 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Drop legacy weigthed_tags methods

https://gerrit.wikimedia.org/r/1114670

dcausse moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Jan 28 2025, 10:34 AM
gerritbot added a comment.Jan 28 2025, 11:13 PM

Change #1114669 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Use WeightedTagsUpdater service in UpdateWeightedTags

https://gerrit.wikimedia.org/r/1114669

gerritbot added a comment.Jan 28 2025, 11:18 PM

Change #1114670 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Drop legacy weighted_tags methods

https://gerrit.wikimedia.org/r/1114670

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.15; 2025-02-04); removed MW-1.44-notes (1.44.0-wmf.14; 2025-01-28).Jan 29 2025, 12:00 AM
dcausse moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Jan 29 2025, 9:54 AM
dcausse moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Feb 10 2025, 4:30 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2025, 4:32 PM
Gehel edited projects, added Discovery-Search (2025.02.10 - 2025.02.28); removed Discovery-Search (Current work).Feb 11 2025, 2:17 PM
Gehel moved this task from Incoming to Done on the Discovery-Search (2025.02.10 - 2025.02.28) board.
dcausse closed this task as Resolved.Feb 11 2025, 2:35 PM
Gehel moved this task from Done to Reported on the Discovery-Search (2025.02.10 - 2025.02.28) board.Feb 14 2025, 8:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits