PHP deprecation: json_decode(): Passing null to parameter #1 from ArticleFeedbackv5Utils
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	BrownKDocs
	Sep 13 2024, 7:41 PM

Description

When I open Special:ArticleFeedback,v5, I get this error message 174 times before the page content:
Deprecated: json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in /var/www/html/extensions/ArticleFeedbackv5/includes/ArticleFeedbackv5Utils.php on line 240

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Avoid passing null to json_decode	mediawiki/extensions/ArticleFeedbackv5	REL1_42	+8 -6
	Avoid passing null to json_decode	mediawiki/extensions/ArticleFeedbackv5	master	+8 -6

Customize query in gerrit

Related Objects

Mentioned Here: rEAFFde146af041c3: specials: Avoid passing null to json_decode

Event Timeline

BrownKDocs created this task.Sep 13 2024, 7:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2024, 7:41 PM

Umherirrender renamed this task from PHP errors at top of special page to PHP deprecation: json_decode(): Passing null to parameter #1 from ArticleFeedbackv5Utils.Sep 13 2024, 7:45 PM

Umherirrender added a project: PHP 8.1 support.

@Umherirrender Wanna take care of this one and the other one in ArticleFeedbackv5Hooks, in the UserLoginComplete hook handler function? Seeing that you started this work back in de146af041c3a569f6a738a93d9a96023ffe1df5 and all... :)

The mention patch set was needed to make CI passing on the extension and to allow further patch sets to merge.

But I can adapt the same changes to the other usage of json_decode in the extension.

Change #1074481 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ArticleFeedbackv5@master] Avoid passing null to json_decode

https://gerrit.wikimedia.org/r/1074481

gerritbot added a project: Patch-For-Review.Sep 20 2024, 4:51 PM

Change #1074481 merged by Jack Phoenix:

[mediawiki/extensions/ArticleFeedbackv5@master] Avoid passing null to json_decode

https://gerrit.wikimedia.org/r/1074481

Thanks for fixing this, @Umherirrender! 👍

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2024, 11:30 PM

Change #1076014 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ArticleFeedbackv5@REL1_42] Avoid passing null to json_decode

https://gerrit.wikimedia.org/r/1076014

gerritbot added a project: Patch-For-Review.Sep 26 2024, 7:52 PM

Change #1076014 merged by Umherirrender: