findDeprecated.php does not correctly label hard-deprecated code
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Sep 16 2024, 10:55 AM

Description

The findDeprecated.php maintenance script allows searching for deprecated code. However, it currently does not correctly report whether code is soft or hard deprecated. The code currently reports all deprecated code as soft-deprecated.

Steps to replicate the issue

Run findDeprecated.php

What happens?:
The output has all methods, including those that are hard-deprecated, marked as soft-deprecated.

What should have happened instead?:
The hard-deprecated code should be marked as such

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
1.43.0-alpha (28f54e3) 21:02, 13 September 2024, PHP 8.1.20 (fpm-fcgi)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	maintenance: Fix inconsistent path ref in findDeprecated.php	mediawiki/core	master	+2 -3
	Test findDeprecated.php	mediawiki/core	master	+133 -9

Customize query in gerrit

Related Objects

Mentioned In: T423054: Fix FindDeprecatedTest.php to pass on PHP 8.2, 8.3, 8.4, and 8.5
T243403: Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo
Mentioned Here: rSANI28f54e31f30b: Update patch set 1

Event Timeline

Dreamy_Jazz created this task.Sep 16 2024, 10:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2024, 10:55 AM

Dreamy_Jazz updated the task description. (Show Details)Sep 16 2024, 10:55 AM

Change #1073181 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Test findDeprecated.php

https://gerrit.wikimedia.org/r/1073181

gerritbot added a project: Patch-For-Review.Sep 16 2024, 11:13 AM

Dreamy_Jazz claimed this task.Sep 16 2024, 11:52 AM

Dreamy_Jazz mentioned this in T243403: Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo.Sep 16 2024, 12:48 PM

Change #1073181 merged by jenkins-bot:

[mediawiki/core@master] Test findDeprecated.php

https://gerrit.wikimedia.org/r/1073181

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2024, 6:30 PM

Dreamy_Jazz closed this task as Resolved.Oct 16 2024, 9:30 AM

Krinkle mentioned this in T423054: Fix FindDeprecatedTest.php to pass on PHP 8.2, 8.3, 8.4, and 8.5.Sun, Apr 12, 7:21 PM

Change #1270272 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] maintenance: Fix inconsistent path ref in findDeprecated.php

https://gerrit.wikimedia.org/r/1270272

gerritbot added a project: Patch-For-Review.Mon, Apr 13, 5:30 AM

Change #1270272 merged by jenkins-bot: