Page MenuHomePhabricator
Create Task
Maniphest T374855

Hide the value of gbw_address in the public replicas if the associated globalblocks table row has gb_autoblock_parent_id as not null
Closed, DeclinedPublic2 Estimated Story Points
Actions

Description

The gbw_address should be hidden from public replicas if the value of the gb_autoblock_parent_id column is not null for the associated globalblocks row. This is to ensure that the IP that was autoblocked is not visible, in a similar way that the bt_address column is hidden if bt_auto is set to 1.

This probably involves updating https://gerrit.wikimedia.org/g/operations/puppet/+/de042c8e3894b03f9b28b42a391d4d1e0c30e0d2/modules/profile/templates/wmcs/db/wikireplicas/maintain-views.yaml to have a custom view.

Acceptance critera
  • Ensure that the gbw_address column is hidden from public replicas when the associated gb_autoblock_parent_id column is not null

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Sep 16 2024, 2:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2024, 2:41 PM
Dreamy_Jazz removed a project: Epic.Sep 16 2024, 2:41 PM
Dreamy_Jazz edited projects, added Data-Services, Data-Engineering; removed Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).
Dreamy_Jazz moved this task from Backlog to Wiki replicas on the Data-Services board.
Dreamy_Jazz set the point value for this task to 2.Sep 16 2024, 2:46 PM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)).
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Beatboxing (Sept 16-27)) board.
Dreamy_Jazz added a parent task: T374853: Update the GlobalBlockManager service to support global autoblocks.Sep 16 2024, 3:03 PM
Dreamy_Jazz renamed this task from Hide the value of gbw_address in the global_block_whitelist table if the associated gb_id has gb_autoblock_parent_id as not null to Hide the value of gbw_address in the public replicas if the associated gb_id has gb_autoblock_parent_id as not null.Sep 16 2024, 3:51 PM
Dreamy_Jazz renamed this task from Hide the value of gbw_address in the public replicas if the associated gb_id has gb_autoblock_parent_id as not null to Hide the value of gbw_address in the public replicas if the associated globalblocks table row has gb_autoblock_parent_id as not null.
Dreamy_Jazz closed this task as Declined.Sep 17 2024, 11:43 AM

This won't work because the globalblocks table is not on the same database as the global_block_whitelist tables, so when constructing the view it will fail to generate it.

Instead of hiding rows in that table, we should remove the gbw_address and gbw_target_central_id columns. This is possible because the code which checks for a local disable always uses the gbw_id to look for the relevant entry.

Dreamy_Jazz mentioned this in T374937: Drop gbw_address and gbw_target_central_id from the global_block_whitelist table.Sep 17 2024, 12:12 PM
Dreamy_Jazz removed a parent task: T368949: [Epic] Implement global autoblocks from global user blocks.Sep 17 2024, 12:24 PM
Dreamy_Jazz mentioned this in T375184: Apply a default to gbw_address in the global_block_whitelist table.Sep 19 2024, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits